Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix should_store_decisions_for_pending_withdrawal_requests test #1466

Open
2 tasks
MCJOHN974 opened this issue Mar 4, 2025 · 0 comments
Open
2 tasks

[Bug]: Fix should_store_decisions_for_pending_withdrawal_requests test #1466

MCJOHN974 opened this issue Mar 4, 2025 · 0 comments
Assignees
@MCJOHN974
Labels
bug Something isn't working chore P0 Critical Priority unplanned An issue that was originally not part of the Milestone planning
Milestone
sBTC: Withdrawal ...

Comments

@MCJOHN974
Copy link
Collaborator

MCJOHN974 commented Mar 4, 2025 •
edited
Loading

Bug - Fix should_store_decisions_for_pending_withdrawal_requests test

1. Description

As #1465 shows, should_store_decisions_for_pending_withdrawal_requests breaks if we change seed. We need to investigate why it happens, and fix it

2. Why It's Necessary

There is no explanation why this test needs fixed seed and we ok if it fails with another seed

3. Execution Checklist

  • investigate why it happens
  • fix it
@MCJOHN974 MCJOHN974 added the chore label Mar 4, 2025
@MCJOHN974 MCJOHN974 self-assigned this Mar 4, 2025
@MCJOHN974 MCJOHN974 added this to sBTC Mar 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Mar 4, 2025
@MCJOHN974 MCJOHN974 added this to the sBTC: Withdrawal fine tuning milestone Mar 4, 2025
@MCJOHN974 MCJOHN974 added bug Something isn't working P0 Critical Priority unplanned An issue that was originally not part of the Milestone planning labels Mar 4, 2025
@MCJOHN974 MCJOHN974 changed the title [Chore]: Fix should_store_decisions_for_pending_withdrawal_requests test [Bug]: Fix should_store_decisions_for_pending_withdrawal_requests test Mar 4, 2025
@MCJOHN974 MCJOHN974 mentioned this issue Mar 4, 2025
Open
4 tasks
@MCJOHN974 MCJOHN974 moved this from Needs Triage to In Progress in sBTC Mar 4, 2025
@djordon djordon moved this from In Progress to Todo in sBTC Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MCJOHN974 MCJOHN974

Labels
bug Something isn't working chore P0 Critical Priority unplanned An issue that was originally not part of the Milestone planning
Projects
sBTC
Status: Todo
Milestone
sBTC: Withdrawal fine tuning
Development

No branches or pull requests
1 participant
@MCJOHN974