Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: Use wrapper structs for bitcoin and stacks block height #1405

Open
2 tasks
MCJOHN974 opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1448
Open
2 tasks

[Chore]: Use wrapper structs for bitcoin and stacks block height #1405

MCJOHN974 opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1448
Assignees
@MCJOHN974
Labels
chore good first issue Good for newcomers P3 Low Priority
Milestone
sBTC: Withdrawal ...

Comments

@MCJOHN974
Copy link
Collaborator

Chore - Use wrapper structs for bitcoin and stacks block height

1. Description

We want to create structs like struct BitcoinBlockHeight(u64) and struct StacksBlockHeight(u64) and switch from using raw integers to using this structs

2. Why It's Necessary

It shows semantics of variable more explicitly. It can prevent some confusions and misunderstandings.

3. Execution Checklist

  • structs for bitcoin and stacks heights are implemented with all necessary functions
  • all raw integers representing stacks/bitcoin block height replaced by this structs
@MCJOHN974 MCJOHN974 added chore good first issue Good for newcomers P3 Low Priority labels Feb 20, 2025
@MCJOHN974 MCJOHN974 added this to the sBTC: Nice to have milestone Feb 20, 2025
@MCJOHN974 MCJOHN974 added this to sBTC Feb 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Feb 20, 2025
@MCJOHN974 MCJOHN974 self-assigned this Feb 26, 2025
@MCJOHN974 MCJOHN974 moved this from Needs Triage to In Progress in sBTC Feb 26, 2025
@MCJOHN974 MCJOHN974 linked a pull request Feb 28, 2025 that will close this issue
Open
4 tasks
@djordon djordon moved this from In Progress to In Review in sBTC Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MCJOHN974 MCJOHN974

Labels
chore good first issue Good for newcomers P3 Low Priority
Projects
sBTC
Status: In Review
Milestone
sBTC: Withdrawal fine tuning
Development

Successfully merging a pull request may close this issue.

[chore]: use wrapper structs for heights stacks-network/sbtc
1 participant
@MCJOHN974