Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Validate the coordinator proposed stacks fees #1439

Open
1 task
djordon opened this issue Feb 26, 2025 · 0 comments · May be fixed by #1430
Open
1 task

[Bug]: Validate the coordinator proposed stacks fees #1439

djordon opened this issue Feb 26, 2025 · 0 comments · May be fixed by #1430
Assignees
Labels
breaking-protocol Breaking protocol changes bug Something isn't working immunefi-scope sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Feb 26, 2025

Feature - Validate the coordinator proposed stacks fees

1. Description

There is nothing preventing a coordinator from proposing large fees for Stacks transactions. This ticket is to fix that by validating fees.

2. Technical Details:

For the initial implementation of fee validation, we should aim to ensure that the proposed fee is under some maximum. Later we can add something fancier for fee estimation, such as having everyone submit their vote on the fee and having the coordinator propose the median or something like that.

2.1 Acceptance Criteria:

  • Unreasonably large Stacks fees are rejected by the signers.

3. Related Issues and Pull Requests (optional):

@djordon djordon added bug Something isn't working breaking-protocol Breaking protocol changes immunefi-scope labels Feb 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Feb 26, 2025
@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Feb 26, 2025
@djordon djordon moved this from Needs Triage to In Review in sBTC Feb 26, 2025
@djordon djordon added this to the sBTC: Withdrawal fine tuning milestone Feb 26, 2025
@djordon djordon assigned djordon and unassigned AshtonStephens Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-protocol Breaking protocol changes bug Something isn't working immunefi-scope sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants