Issue #1: Configure nodes when already powered off

Author: stack

library/drac.py

@@ -902,12 +902,14 @@ def flush(module, bmc):
     :param bmc: A dracclient.client.DRACClient instance
     """
     debug(module, "Flushing BIOS and/or RAID settings by rebooting")
-    # Reboot the node.
+    current_state = bmc.get_power_state()
+    goal_state = 'POWER_ON' if current_state == 'POWER_OFF' else 'REBOOT'
+    # Reboot or power on the node.
     try:
-        bmc.set_power_state('REBOOT')
+        bmc.set_power_state(goal_state)
     except drac_exc.BaseClientException as e:
-        module.fail_json(msg="Failed to reboot to apply pending BIOS "
-                         "settings: %s" % repr(e))
+        module.fail_json(msg="Failed to set power state to %s to apply "
+                         "pending BIOS settings: %s" % (goal_state, repr(e)))
 
     # Wait for the reboot to flush pending jobs.
     try:
@@ -916,6 +918,14 @@ def flush(module, bmc):
         module.fail_json(msg="Failed waiting for reboot to flush "
                          "pending BIOS settings: %s" % repr(e))
 
+    # Power off the node if it was previously powered off.
+    if current_state == 'POWER_OFF':
+        try:
+            bmc.set_power_state('POWER_OFF')
+        except drac_exc.BaseClientException as e:
+            module.fail_json(msg="Failed to set power state to off: %s"
+                             % repr(e))
+
 
 def abandon_bios(module, bmc):
     """Abandon uncommitted pending BIOS configuration changes.

tests/test_drac.py

@@ -1133,6 +1133,7 @@ def test_configure_bios(self, mock_wait, mock_raid, mock_bios, mock_build):
         }
         self.module.check_mode = False
         self.bmc.list_jobs.side_effect = [[FakeJob('ConfigBIOS')], []]
+        self.bmc.get_power_state.return_value = 'POWER ON'
         drac.configure(self.module)
         self.bmc.set_bios_settings.assert_called_once_with({'NumLock': 'On'})
         self.bmc.commit_pending_bios_changes.assert_called_once_with(False)
@@ -1166,6 +1167,7 @@ def test_configure_raid(self, mock_wait, mock_raid, mock_bios, mock_build):
         }
         self.module.check_mode = False
         self.bmc.list_jobs.side_effect = [[FakeJob('ConfigBIOS')], []]
+        self.bmc.get_power_state.return_value = 'POWER ON'
         drac.configure(self.module)
         self.bmc.convert_physical_disks.assert_called_once_with(
             'controller1', ['pdisk1'])