Provide useful error from topology if no instances found (#884)

* add eessi cvmfs config and re-enable gpg checks everywhere

* disable fail2ban gpg check provisionally

* Install epel-release gpg for rocky 8

* gpg check option correction

* manual dl and install of epel-release key

* correct epel-release signing key

* dnf install rocky-gpg-keys

* stop using rpm_key module for rockyofficial key

* test timestamps setting gpgkey

* hardcode ceph key in dnf_repos defaults

* preserve ceph key newlines

* disable gpg checks for ceph repo packages

* rocky 8/9 compatibility chnages

* correct epel gpg key in timestamps

* import EPEL key

* hardcode cernvm gpg key

* disable gpgcheck for cvmfs eessi config (not provided upstream)

* disable gpgchecks for some repos provisionally

* Bump CI images

* move dnf_repos gpg key imports to top, consistent gpgchecks, comments

* refactor GPG key import

* remove incorrect grafana repo timestamp

* add cernvmfs EESSI config repo

* wip: fix ceph packages not matching gpg key

* add correct ceph key from centos stream storage SIG

* cope with cvmfs config package not being signed

* move gpg keys for repos handled by dnf_repos into dnf_repos

* update dnf repos/gpg key docs and comments

[skip ci]

* autofix lint errors

[skip ci]

* bump CI image

* bump manila role to release

* fix lint errors

* skip checkov error on unsigned cvmfs config package

* remove dev comments

* fix docs lint errors

* useful error if topology can't get host ids

[no ci]

* fix black/pylint lint error

* shorten msg to meet flake8 limit

---------

Co-authored-by: bertiethorpe <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>

Author: sjpb

ansible/roles/topology/library/map_hosts.py

@@ -82,6 +82,11 @@ def run_module():  # pylint: disable=missing-function-docstring
                 topo[az][host_id] = []
             topo[az][host_id].append(s["name"])
 
+    if len(all_host_ids) == 0:
+        module.fail_json(
+            msg="No host_ids retrieved for servers - are OpenStack credentials correct?"
+        )
+
     uuid_len = min_prefix(list(set(all_host_ids)))
 
     for az in topo: