Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version incorrectly reported #51

Open
staabm opened this issue Sep 10, 2020 · 3 comments
Open

Version incorrectly reported #51

staabm opened this issue Sep 10, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@staabm
Copy link
Owner

staabm commented Sep 10, 2020 •
edited

The version constant is not updated properly

On cs2pr 1.3.0 calling cs2pr --version reports 1.1.0-dev

annotate-pull-request-from-checkstyle/cs2pr

Line 19 in 53b2823

$version = '1.1.1-dev';

@staabm staabm mentioned this issue Sep 10, 2020
Closed
@staabm staabm changed the title Version incorrectly reporter Version incorrectly reported Sep 10, 2020
@staabm staabm mentioned this issue Sep 10, 2020
Merged
@staabm
Copy link
Owner Author

staabm commented Sep 12, 2020

The initial problem was fixed.

Would be great to have this automated as a next step

@donatj
Copy link
Contributor

donatj commented May 6, 2021

This looks like it's out of sync again.

@staabm staabm mentioned this issue May 6, 2021
Merged
@staabm
Copy link
Owner Author

staabm commented May 6, 2021

Thx for the hint. Manually patched again.

Would be great someone could provide a fix for the release automation

@staabm staabm added help wanted Extra attention is needed bug Something isn't working labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staabm @donatj