Skip to content

Commit 560ff3b

Browse files
committed
Fix leak-prone CustomData in stdMem interface. Use std::unique_ptr to
give ownership of `CustomData` to `CustomRequest` and `CustomResponse` classes.
1 parent fd63753 commit 560ff3b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/sst/core/interfaces/stdMem.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -913,9 +913,9 @@ class StandardMem : public SubComponent
913913
return str.str();
914914
}
915915

916-
CustomData* data; /* Custom class that holds data for this event */
917-
Addr iPtr; /* Instruction pointer */
918-
uint32_t tid; /* Thread ID */
916+
std::unique_ptr<CustomData> data; /* Custom class that holds data for this event */
917+
Addr iPtr; /* Instruction pointer */
918+
uint32_t tid; /* Thread ID */
919919
};
920920

921921
class CustomResp : public Request
@@ -951,9 +951,9 @@ class StandardMem : public SubComponent
951951
return str.str();
952952
}
953953

954-
CustomData* data; /* Custom class that holds data for this event */
955-
Addr iPtr; /* Instruction pointer */
956-
uint32_t tid; /* Thread ID */
954+
std::unique_ptr<CustomData> data; /* Custom class that holds data for this event */
955+
Addr iPtr; /* Instruction pointer */
956+
uint32_t tid; /* Thread ID */
957957
};
958958

959959
/* Class for implementation-specific converter functions */

0 commit comments

Comments
 (0)