New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 5 suggestion #96
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've found a bit confusing the fact that at master branch in
triangle(..)
there isbc_clip
argument which is assuming we have already performed clipping. But the course Wiki says it is projection that helps us to clip vertices. And in the code we see Projection applied tobc_clip
(already clipped?) vertices. Maybe I miss something..But I think it may be useful to note that if we know parameter
r=1/D
whereD
is screen-plane-to-camera distance and planes Z=0, Z=farthest_distance, we can clip vertices before applying Projection matrix and that will bring meaning tobc_clip
argument name.What do you think?
The text was updated successfully, but these errors were encountered: