Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling obsolete, historic codes like ISO 3166-1:AN #10

Open
cschug opened this issue Feb 10, 2022 · 3 comments
Open

Handling obsolete, historic codes like ISO 3166-1:AN #10

cschug opened this issue Feb 10, 2022 · 3 comments

Comments

@cschug
Copy link

cschug commented Feb 10, 2022

The country code AN (Netherlands Antilles) has been removed in 2010 per ISO 3166-1 Newsletter VI-8.

I'm not sure what the best way would to handle such cases.

The easiest option would be to remove that entry from the list (as it isn't part of the standard anymore) and be done with it.

On the other hand it might be feasible to introduce an obsoleted_by property referencing the document mentioned above and add an optional parameter to relevant methods whether to include or exclude obsolete records. Or maybe even show obsolete records only? The default behavior should most likely reflect the current standard and exclude obsolete records and show only the active ones.

@sshaw
Copy link
Owner

sshaw commented Feb 12, 2022

Good questions.

I would ask is the library's purpose to maintain standards or to simply normalize? Certainly normalizing does require us to "maintain standards", e.g., when a name or code is added, but if something was obsoleted, what is the downside to keeping it in?

To ask a different way: do we normalize and validate or just normalize?

I would think if validation was necessary you'd use one of these to check on it before passing it to NormalizeCountry().

Thoughts?

@cschug
Copy link
Author

cschug commented Feb 14, 2022

That's a valid point of view.

Nevertheless most current systems won't expand the sequence of "\U0001F1E6" (REGIONAL INDICATOR SYMBOL LETTER A) and "\U0001F1F3" (REGIONAL INDICATOR SYMBOL LETTER N) into a flag anymore, which renders the emoji pretty useless and might lead to unexpected results (it's basically an invalid Unicode region code).

@sshaw
Copy link
Owner

sshaw commented Mar 22, 2022

Nevertheless most current systems won't expand the sequence of "\U0001F1E6"...

Thanks for the info. Can you provide an example of where this is not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants