-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git push not working, when intercepted with SSH-MITM #131
Comments
I have added a fix, which should work with most git commands: e2a2212 @hc-dev991 can you check, if it is working for you |
Thanks the prompt responses! now as I do more testing on another machine, I discovered another behavior:
but the push of new commit is successful to the remote github branch this is observed on the new machine both before the workaround commit (direct installation using |
@hc-dev991 have you tested the fix and is it working for you? |
@manfred-kaiser yes I got my git version 2.39.2 Before e2a2212
After e2a2212
|
@hc-dev991 Thanks for testing. It seems that GitHub works different to other code hosters/git implementations. During my tests I'm working with "Gitea", which is an selfhosted alternative to GitHub. I will try to fix it for Github. |
I have created a fix/workarround for Github. Github and Gitea have different implementations 😞 It seems, Github needs to close the session on EOF in some cases, while Gitea does not need this. There are more git commands, which needs to be tested. At the moment, Gitea is my major test platform for git, because this is selfhosted and I can do as much tests as I want. Using Github might be more interesting for most users, but I need more test accounts, because too much failed tests can result in blocked users. |
Hello @manfred-kaiser,
Your post about ssh-mitm around git audits was pretty helpful.
I was able to configure ssh-mitm to audit
git clone
commands to github remote repo from my local, using configs mentioned in this thread as well as in https://docs.ssh-mitm.at/user_guide/advanced-usage.html.However, when trying to do writes on the same branch (tracking github remote branch),
git push
fails with error:and on the ssh-mitm process, the output was
note: not seeing the remote command exit code, while I was expecting something like
Question:
ssh-mitm
does not work forgit push
?git clone
working but notgit push
? Is it becausessh-mitm
implements some of the git protocol but not all?Appreciate your help!
Originally posted by @hc-dev991 in #115 (comment)
The text was updated successfully, but these errors were encountered: