Skip to content

Commit 102fb9d

Browse files
Teemperorvgvassilev
authored andcommitted
Always pass -fcolor-diagnostics to clang.
Otherwise everyone using ninja to build is lacking colors.
1 parent bba80a1 commit 102fb9d

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

cmake/modules/CheckCompiler.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,12 @@ if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
3333
string(REGEX REPLACE "^.*[ ]version[ ][0-9]+\\.([0-9]+).*" "\\1" CLANG_MINOR "${_clang_version_info}")
3434
message(STATUS "Found Clang. Major version ${CLANG_MAJOR}, minor version ${CLANG_MINOR}")
3535
set(COMPILER_VERSION clang${CLANG_MAJOR}${CLANG_MINOR})
36+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fcolor-diagnostics")
37+
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fcolor-diagnostics")
3638
if(ccache)
3739
# https://bugzilla.samba.org/show_bug.cgi?id=8118 and color.
38-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qunused-arguments -fcolor-diagnostics")
39-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Qunused-arguments -fcolor-diagnostics")
40+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qunused-arguments")
41+
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Qunused-arguments")
4042
endif()
4143
else()
4244
set(CLANG_MAJOR 0)

0 commit comments

Comments
 (0)