Skip to content
This repository was archived by the owner on Mar 9, 2023. It is now read-only.

Commit 3908d96

Browse files
authored
Merge pull request #105 from srinandan/issue104
fixes incorrect connector para #104
2 parents 43a91c5 + 31f32b4 commit 3908d96

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

client/integrations/integrations.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ type parameterInternal struct {
109109
}
110110

111111
type parameterExternal struct {
112-
Key string `json:"key,omitempty"`
113-
DataType string `json:"dataType,omitempty"`
114-
DefaultValue valueType `json:"defaultValue,omitempty"`
115-
Name string `json:"name,omitempty"`
116-
IsTransient bool `json:"isTransient,omitempty"`
117-
InputOutputType string `json:"inputOutputType,omitempty"`
118-
Producer string `json:"producer,omitempty"`
119-
Searchable bool `json:"searchable,omitempty"`
120-
JsonSchema string `json:"jsonSchema,omitempty"`
112+
Key string `json:"key,omitempty"`
113+
DataType string `json:"dataType,omitempty"`
114+
DefaultValue *valueType `json:"defaultValue,omitempty"`
115+
Name string `json:"name,omitempty"`
116+
IsTransient bool `json:"isTransient,omitempty"`
117+
InputOutputType string `json:"inputOutputType,omitempty"`
118+
Producer string `json:"producer,omitempty"`
119+
Searchable bool `json:"searchable,omitempty"`
120+
JsonSchema string `json:"jsonSchema,omitempty"`
121121
}
122122

123123
type producedBy struct {
@@ -147,10 +147,10 @@ type taskconfig struct {
147147
NextTasksExecutionPolicy string `json:"nextTasksExecutionPolicy,omitempty"`
148148
TaskExecutionStrategy string `json:"taskExecutionStrategy,omitempty"`
149149
JsonValidationOption string `json:"jsonValidationOption,omitempty"`
150-
SuccessPolicy successPolicy `json:"successPolicy,omitempty"`
150+
SuccessPolicy *successPolicy `json:"successPolicy,omitempty"`
151151
TaskTemplate string `json:"taskTemplate,omitempty"`
152-
FailurePolicy failurePolicy `json:"failurePolicy,omitempty"`
153-
SynchronousCallFailurePolicy failurePolicy `json:"synchronousCallFailurePolicy,omitempty"`
152+
FailurePolicy *failurePolicy `json:"failurePolicy,omitempty"`
153+
SynchronousCallFailurePolicy *failurePolicy `json:"synchronousCallFailurePolicy,omitempty"`
154154
}
155155

156156
type eventparameter struct {

client/integrations/overrides.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ type connectiondetails struct {
6060
}
6161

6262
type connectionparams struct {
63-
ServiceName string `json:"serviceName,omitempty"`
64-
ConnectionName string `json:"connectionName,omitempty"`
65-
ConnectionVersion string `json:"connectionVersion,omitempty"`
63+
ServiceName string `json:"serviceName,omitempty"`
64+
ConnectionName string `json:"connectionName,omitempty"`
65+
ConnectorVersion string `json:"connectorVersion,omitempty"`
6666
}
6767

6868
const pubsubTrigger = "cloud_pubsub_external_trigger/projects/cloud-crm-eventbus-cpsexternal/subscriptions/"
@@ -134,7 +134,7 @@ func mergeOverrides(eversion integrationVersionExternal, o overrides, supressWar
134134
}
135135

136136
cd.Connection.ConnectionName = newcp.ConnectionName
137-
cd.Connection.ConnectionVersion = newcp.ConnectionVersion
137+
cd.Connection.ConnectorVersion = newcp.ConnectorVersion
138138
cd.Connection.ServiceName = newcp.ServiceName
139139

140140
jsonValue, err := stringifyValue(cd)
@@ -221,7 +221,7 @@ func getNewConnectionParams(connectionName string, connectionLocation string) (c
221221
return cp, err
222222
}
223223

224-
cp.ConnectionVersion = fmt.Sprintf("%v", connectionVersionResponse["connectorVersion"])
224+
cp.ConnectorVersion = fmt.Sprintf("%v", connectionVersionResponse["connectorVersion"])
225225
cp.ServiceName = fmt.Sprintf("%v", connectionVersionResponse["serviceDirectory"])
226226
cp.ConnectionName = fmt.Sprintf("%v", connectionVersionResponse["name"])
227227

0 commit comments

Comments
 (0)