Gitattributes #50

dpaz · 2017-06-23T08:43:35Z

Added support for .gitattributes which works similar to github/linguist
#18

smola

This will not work on bare repositories. Let's think how we should modify the API so that it does.

README.md

utils.go

mcarmonaa · 2017-06-26T06:48:59Z

utils.go

+ return nil, err
+ }
+
+ if data != nil {


If you actually want to avoid the code inside the if statement, you should check for len(data) > 0, if ioutil.ReadFile doesn't fail it could return an empty slice and an empty slice in not nil.

mcarmonaa · 2017-06-26T06:49:18Z

utils.go

+
+ if data != nil {
+ tokens := strings.Fields(string(data))
+ for i := 0; i < len(tokens); i = i + 2 {


Maybe you should use a scanner or split before by lines, it's not so clear what are you doing here at a glance

mcarmonaa · 2017-06-26T06:49:28Z

utils.go

+
+func parseAttributes(attributes map[string]string) {
+ for key, val := range attributes {
+ switch {


what happens if the same path has several attributes?

mcarmonaa · 2017-06-26T06:49:38Z

utils.go

+ }
+}
+
+func LoadGitAttributes() {


put this function before loadGitattributes() and add a comment if it is a public function

mcarmonaa · 2017-06-26T06:50:49Z

common.go

@@ -87,6 +88,12 @@ func GetLanguageByClassifier(content []byte, candidates []string) (language stri
 return getLanguageByStrategy(GetLanguagesByClassifier, "", content, candidates)
 }

+// GetLanguageByGitAttributes returns the language assigned for a given regular expresion in .gitattributes.
+// This strategy needs to be initialized callin LoadGitAttributes


s/callin/calling/

Can we do this on demand instead of having to call LoadGitAttributes?

What is the argument to this function? a filename or a regular expression (function signature says the former, comment explains the later)

mcarmonaa · 2017-06-26T06:51:58Z

README.md

@@ -33,6 +33,7 @@ fmt.Println(lang)
 lang := enry.GetLanguage("foo.cpp", "<cpp-code>")
 ```

+
 Developmemt
 -----------
 *enry* re-uses parts of original [linguist](https://github.com/github/linguist) especially data in `languages.yml` to generate internal data structures. In oreder to update to latest upstream run


s/oreder/order/

mcarmonaa · 2017-06-26T06:54:33Z

@dpaz You should add tests for new functionality

mcarmonaa · 2017-06-26T07:11:24Z

utils.go

+ if len(tokens) == 2 {
+ regExp, err := regexp.Compile(regExpString)
+ if err == nil {
+ languageGitAttributes[regExp] = tokens[1]


you should pass tokens[1] to GetLanguageByAlias() before store it in the map, this ensures the language will be stored like a "standard name" if it is a known language for enry

alcortesm · 2017-06-26T09:43:14Z

common.go

@@ -87,6 +88,12 @@ func GetLanguageByClassifier(content []byte, candidates []string) (language stri
 return getLanguageByStrategy(GetLanguagesByClassifier, "", content, candidates)
 }

+// GetLanguageByGitAttributes returns the language assigned for a given regular expresion in .gitattributes.
+// This strategy needs to be initialized callin LoadGitAttributes


Can we do this on demand instead of having to call LoadGitAttributes?

alcortesm · 2017-06-26T09:45:49Z

common.go

@@ -87,6 +88,12 @@ func GetLanguageByClassifier(content []byte, candidates []string) (language stri
 return getLanguageByStrategy(GetLanguagesByClassifier, "", content, candidates)
 }

+// GetLanguageByGitAttributes returns the language assigned for a given regular expresion in .gitattributes.
+// This strategy needs to be initialized callin LoadGitAttributes


What is the argument to this function? a filename or a regular expression (function signature says the former, comment explains the later)

alcortesm · 2017-06-26T09:47:23Z

common.go

@@ -434,3 +441,20 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {

 return
 }
+
+// GetLanguagesByGitAttributes returns the language assigned in .gitattributes if the regular expresion
+// matchs with the filename


Misleading comment: It returns a slice of languages, not a language.

The difference between this method and GetLanguageByGitAttributes should be made much clear and probably their names should be much different also.

Why is this function ignoring most of its arguments?

If it is to implemement and interface, it would be nice to know, and why are they being ignored in this particular implementation. Also give ignored arguments a good name, like _?

I added some info to say that it is implementing an interface, the rest of the things that you are telling me are like this to be coherent with the other strategies that are written similarly.

alcortesm · 2017-06-26T09:51:02Z

common.go

+ return languageByGitAttribute(filename)
+}
+
+func languageByGitAttribute(filename string) []string {


Why does this function exists? can its code be part of its caller body?
Shouldn't it be called languages... instead of language...?

abeaumont · 2017-06-27T09:04:21Z

README.md

+--------------
+
+Like in linguist you can override the strategies via `.gitattributes` file.
+Add a `.gitattributes` file to the directory and use the enry matchers `enry-documentation`,`enry-language` or `enry-vendored` to do the override.


I don't know how linguist works, but why are we using specific enry matchers instead of reusing the linguist ones? Or are we adding these enry matchers on top of the linguist ones?

its only a name, they called linguist-documentation or linguist-vendored because is part of linguist, I thought that because we are on enry we should call it enry-vendored and enry-documentation.

Yes, but if you name them differently you're forcing the user to have to support both linguist and enry separately. If you just use the same name, enry will already support all those attributes already customized by users for linguist, since enry would be fully compatible with linguist.

abeaumont · 2017-06-27T09:05:45Z

utils.go

@@ -66,3 +83,99 @@ func IsBinary(data []byte) bool {

 return true
 }
+
+// LoadGitattributes reads and parse the file .gitattributes wich overrides the standards strategies


s/parse/parses/
s/wich/which/
s/standards/standard/

abeaumont · 2017-06-27T09:07:33Z

utils.go

+ }
+}
+
+func loadGitattributes(name string) (map[string]string, error) {


Ignore me if this is some kind of Go convention, but having 2 functions whose only difference in the name is the case of the first letter seems pretty confunsing to me

abeaumont · 2017-06-27T09:09:04Z

utils.go

+ data, err := ioutil.ReadFile(name)
+ if err != nil {
+ if err != os.ErrNotExist {
+ log.Println(".gitattributes: " + err.Error())


log.Println(name + ": " + err.Error())?

abeaumont · 2017-06-27T09:12:14Z

utils_test.go

@@ -81,6 +82,42 @@ func (s *SimpleLinguistTestSuite) TestIsBinary() {
 }
 }

+func (s *SimpleLinguistTestSuite) TestLoadLine() {


I guess this should be EnryTestSuite as this point :)

yes the PR was not merged till yesterday I will change this

codecov · 2017-06-27T09:38:52Z

Codecov Report

Merging #50 into master will decrease coverage by 0.97%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   84.78%   83.81%   -0.98%     
==========================================
  Files          16       16              
  Lines         940     1044     +104     
==========================================
+ Hits          797      875      +78     
- Misses         84      103      +19     
- Partials       59       66       +7

Impacted Files	Coverage Δ
common.go	`90.73% <100%> (+0.37%)`	⬆️
utils.go	`71.3% <72.91%> (+8.14%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de4d35...0a267e9. Read the comment docs.

alcortesm · 2017-06-27T15:03:42Z

common.go

@@ -434,3 +441,16 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {

 return
 }
+
+// GetLanguagesByGitattributes returns a length 1 slice with the language assigned in .gitattributes if the regular expresion
+// matchs with the filename. It is comply with the signature to be a Strategy type.


Improve the English and the explanation.

Note that it returns an empty slice if the filename does not match any of the rules in .gitattributes. Should this return nil instead?

This should be called GetLanguagesByGitAttributes with an uppercase A. The same for all git attributes functions and variables, except for the name of the file (.gitattributes) itself, of course.

alcortesm · 2017-06-27T15:09:09Z

common.go

+// GetLanguagesByGitattributes returns a length 1 slice with the language assigned in .gitattributes if the regular expresion
+// matchs with the filename. It is comply with the signature to be a Strategy type.
+func GetLanguagesByGitattributes(filename string, content []byte, candidates []string) []string {
+ languages := []string{}


Maybe it is better, to clarify the interface to remove this allocation from here and move it to the return statement, as otherwise we are allocating a slice to return it empty in case the filename does not match any languageGitattributes.

abeaumont · 2017-06-29T12:08:13Z

common.go

@@ -453,9 +453,11 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {
 // GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes


s/lenguage/language/
s/match/matches/

abeaumont · 2017-06-29T12:09:41Z

common.go

@@ -453,9 +453,11 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {
 // GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes
 //or return nil in case of none regexp matchs the filename . It complies with the signature to be a Strategy type.


space before or

s/return/returns/

no space after filename

s/in case of none/in case no/

s/matchs/matches/

abeaumont · 2017-06-29T12:10:14Z

common.go

- for regExp, language := range languageGitAttributes {
- if regExp.MatchString(filename) {
- return []string{language}
+ if loadedGitAttributes != nil {


I don't think having a global variable floating around different files is a good idea.

abeaumont · 2017-06-29T12:14:53Z

utils.go

- err = errors.New(fmt.Sprintf("gitattributes: The matcher %s doesn't exists\n", attribute))
- log.Printf(err.Error())
+func newGitAttributes() *gitAttributes {
+ gA := gitAttributes{


gA is not too meaningful, and it doesn't make sense to upcase the 'A'.
I'd prefer something like 'attrs' or 'attributes', but since really short names are already used elsewhere, at least use proper casing: ga

alcortesm · 2017-06-29T15:26:14Z

common.go

+// GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes
+//or return nil in case of none regexp matchs the filename . It complies with the signature to be a Strategy type.
+func GetLanguagesByGitAttributes(filename string, content []byte, candidates []string) []string {
+ if loadedGitAttributes != nil {


The idiomatic way to do this in Go is to return nil if the loadedGitAttributes is == nil. That way, the happy path of the function (the for loop) has the smallest level of indentation. For a better explanation of this concept, see Golang UK Conference 2016 - Mat Ryer - Idiomatic Go Tricks (https://www.youtube.com/watch?v=yeetIgNeIkc).

Sorry, I approved the PR by mistake, let's try again:

The idiomatic way to do this in Go is to return nil if the loadedGitAttributes is == nil. That way, the happy path of the function (the for loop) has the smallest level of indentation. For a better explanation of this concept, see Golang UK Conference 2016 - Mat Ryer - Idiomatic Go Tricks (https://www.youtube.com/watch?v=yeetIgNeIkc).

alcortesm · 2017-06-29T15:28:05Z

common.go

+// GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes
+//or return nil in case of none regexp matchs the filename . It complies with the signature to be a Strategy type.
+func GetLanguagesByGitAttributes(filename string, content []byte, candidates []string) []string {
+ if loadedGitAttributes != nil {


Sorry, I approved the PR by mistake, let's try again:

The idiomatic way to do this in Go is to return nil if the loadedGitAttributes is == nil. That way, the happy path of the function (the for loop) has the smallest level of indentation. For a better explanation of this concept, see Golang UK Conference 2016 - Mat Ryer - Idiomatic Go Tricks (https://www.youtube.com/watch?v=yeetIgNeIkc).

codecov-io · 2017-07-04T09:46:56Z

Codecov Report

Merging #50 into master will decrease coverage by <.01%.
The diff coverage is 80.83%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   85.03%   85.02%   -0.01%     
==========================================
  Files          16       17       +1     
  Lines         942     1062     +120     
==========================================
+ Hits          801      903     +102     
- Misses         83       99      +16     
- Partials       58       60       +2

Impacted Files	Coverage Δ
common.go	`85.3% <0%> (-5.15%)`	⬇️
gitattributes.go	`89.81% <89.81%> (ø)`
utils.go	`100% <0%> (+26.31%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200c153...11ef5ed. Read the comment docs.

mcarmonaa · 2017-07-04T13:19:28Z

common.go

- if regExp.MatchString(filename) {
- return append(languages, language)
- }
+// GetLanguagesByGitAttributes returns either a string slice with the language if the filename matches with a regExp in .gitattributes


put this function with the rest of the strategies

mcarmonaa · 2017-07-04T13:19:32Z

gitattributes.go

+ language
+)
+
+const _attrType_name = "vendordocumentationgeneratedlanguage"


What are indicating the underscores? I though this is not so idiomatic in Go.

On the other hand, why don't you use the previous constants as a string turning attrType a string type? Seems like it's adding unnecessary complexity, with _attr_index and the method for attrType String

This is autogenerated code by the command tool stringer its the most simple way to do a toString when you got an enum stringer

mcarmonaa · 2017-07-04T13:19:39Z

gitattributes.go

+
+const _attrType_name = "vendordocumentationgeneratedlanguage"
+
+var _attrType_index = [...]uint8{0, 6, 19, 28, 36}


why the underscores?

mcarmonaa · 2017-07-04T13:19:47Z

gitattributes.go

+ path string
+}
+
+func (e *overrideError) Error() string {


should we take attributes overriding as an error?

Well, if an error is found nothing happens when the LoadAttributes function ends, it returns a slice of warnings that you can ignore, I'm only using this for traceability and testing purposes

mcarmonaa · 2017-07-04T13:19:59Z

gitattributes.go

+
+// IsVendor returns whether or not path is a documentation path.
+func (gitAttrs *GitAttributes) IsDocumentation(path string) bool {
+ if val, ok := gitAttrs.boolAttributes[documentation].attributes[path]; ok {


Maybe you can keep only those attributes which are "true". If the attribute is not in the map it's false, so you can check if the attribute is in the map.
if _, ok := gitAttrs.boolAttributes[documentation].attributes[path]; ok { return ok }

In this way, if we eventually allow attributes overriding, when load an attribute set to false, look for it in the map to delete it

mcarmonaa · 2017-07-04T13:20:09Z

gitattributes.go

+ }
+ }
+
+ return ""


return OtherLanguage

mcarmonaa · 2017-07-04T13:20:22Z

gitattributes.go

+func NewGitAttributes() *GitAttributes {
+ gitAttrs := GitAttributes{
+ boolAttributes: map[attrType]boolAttribute{
+ vendor: boolAttribute{kind: vendor, matchers: []string{"linguist-vendored", "linguist-vendored=false"}, attributes: map[string]bool{}},


If attrType were a string, you could remove the "kind" field from boolAttribute and regExpAttribute. In fact, the kind of these structs should be their type. If a type needs to explicitly keep a "kind" maybe it should be several types with perhaps a common parent type

mcarmonaa · 2017-07-04T13:20:45Z

gitattributes.go

+ return append(gitAttrs.parseAttributes(path, rawAttributes), errArr...)
+}
+
+func (gitAttrs *GitAttributes) String() string {


Why this function is needed?

mcarmonaa · 2017-07-04T13:20:50Z

gitattributes.go

+
+ for key, val := range gitAttrs.regExpAttributes {
+ out += fmt.Sprintf("Type: %s Attributes: %v\n", key, val.attributes)
+ }


add an empty line after this one

mcarmonaa · 2017-07-04T13:20:53Z

gitattributes.go

+ for _, line := range lines {
+ err := loadLine(line, rawAttributes)
+ if err != nil {
+ errArr = append(errArr, err)


If we found a malformed .gitattributes file, we can return a "malformed error" and return nil and one error.

I don't know if we should allow to load a malformed .gitattributes file and return a slice of errors. We can be sure that the rest of attributes are ok if there are errors in the file?

abeaumont · 2017-07-05T10:25:42Z

common.go

@@ -410,6 +410,24 @@ func GetLanguagesBySpecificClassifier(content []byte, candidates []string, class
 return classifier.Classify(content, mapCandidates)
 }

+// GetLanguagesByGitAttributes returns either a string slice with the language if the filename matches with a regExp in .gitattributes


These rows are too long

abeaumont · 2017-07-05T10:25:56Z

common.go

@@ -410,6 +410,24 @@ func GetLanguagesBySpecificClassifier(content []byte, candidates []string, class
 return classifier.Classify(content, mapCandidates)
 }

+// GetLanguagesByGitAttributes returns either a string slice with the language if the filename matches with a regExp in .gitattributes
+//or returns a empty slice in case no regexp matches the filename. It complies with the signature to be a Strategy type.


space befor 'or'

abeaumont · 2017-07-11T08:48:49Z

@dpaz Apart from the review changes, please rebase.

abeaumont · 2017-07-14T12:38:15Z

README.md

@@ -139,6 +139,36 @@ Using [linguist/samples](https://github.com/github/linguist/tree/master/samples)
 * all files for SQL language fall to the classifier because we don't parse this [disambiguator expresion](https://github.com/github/linguist/blob/master/lib/linguist/heuristics.rb#L433) for `*.sql` files right. This expression doesn't comply with the pattern for the rest of [heuristics.rb](https://github.com/github/linguist/blob/master/lib/linguist/heuristics.rb) file.


+.gitAttributes


all lowercase

abeaumont · 2017-07-14T12:38:29Z

README.md

+Use the `linguist-vendored` attribute to vendor or un-vendor paths.
+
+```
+$cat .gitattributes


space before cat

abeaumont · 2017-07-14T12:38:52Z

README.md

+If you want some files to be classified according to certain language use `linguist-language=[language]`.
+
+```
+$cat .gitattributes


space before cat

abeaumont · 2017-07-14T12:39:08Z

README.md

+.*\.go linguist-language=MyFavouriteLanguage
+```
+Note, that the regular expression that match the file name should be one compatible with go, see: [Golang regexp](https://golang.org/pkg/regexp/).
+>>>>>>> 18e17c9... Added support for language attribute


this should not be here

abeaumont · 2017-07-14T12:40:23Z

README.md

+$cat .gitattributes
+.*\.go linguist-language=MyFavouriteLanguage
+```
+Note, that the regular expression that match the file name should be one compatible with go, see: [Golang regexp](https://golang.org/pkg/regexp/).


s/Note, that/Note that/

s/match/matches/

s/be one/be/

abeaumont · 2017-07-14T12:41:50Z

cli/enry/main.go

+ }
+
+ language := gitAttributes.GetLanguage(filepath.Base(path))
+ if len(language) == 0 {


language == enry.OtherLanguage?

abeaumont · 2017-07-18T10:52:55Z

@mcarmonaa can you validate if everything is ok from your side?

mcarmonaa · 2017-07-19T06:23:57Z

README.md

+--------------
+
+Like in linguist you can override the strategies via `.gitattributes` file.
+Add a `.gitattributes` file to the directory and use the same matchers that you would uses in linguist `linguist-documentation`,`linguist-language` or `linguist-vendored` to do the override.


s/uses/use/

mcarmonaa · 2017-07-19T06:28:24Z

README.md

+
+```
+$ cat .gitattributes
+.*\.go linguist-language=MyFavouriteLanguage


If the regex must be compatible with Golang regexp, does it mean that a .gitattribute file used in linguist has a different syntax? Does it make .gitattributes files for enry incompatibles with linguist ones?

mcarmonaa · 2017-07-19T06:33:13Z

common.go

@@ -407,6 +414,25 @@ func GetLanguagesBySpecificClassifier(content []byte, candidates []string, class
 return classifier.Classify(content, mapCandidates)
 }

+// GetLanguagesByGitAttributes returns either a string slice with the language
+// if the filename matches with a regExp in .gitattributes or returns a empty slice


s/a empty/an empty/

mcarmonaa · 2017-07-19T06:46:22Z

As linguist's README says: Add a .gitattributes file to your project and use standard git-style path matchers for the files you want to override..., If we have a different way to specify a path and don't support the same style that linguist uses, we won't be compatible.

The same .gitattributes file should work with linguist and enry.

dpaz · 2017-07-19T08:36:49Z

Like @mcarmonaa is saying, I don't really know If go regexps are a superset of git path matchers, If they are this will be fully compatible, if not we need to add some intermediate regexp motor, a converter or something.

abeaumont · 2017-07-19T10:20:42Z

@dpaz how does linguist implement those regexps?

vmarkovtsev · 2018-01-31T09:08:31Z

We need a hero to finish this!

dpaz requested review from mcarmonaa and smola June 23, 2017 08:43

dpaz changed the title ~~Gitatributes~~ Gitattributes Jun 23, 2017

smola suggested changes Jun 23, 2017

View reviewed changes

README.md Outdated Show resolved Hide resolved

mcarmonaa suggested changes Jun 26, 2017

View reviewed changes

alcortesm suggested changes Jun 26, 2017

View reviewed changes

abeaumont suggested changes Jun 27, 2017

View reviewed changes

dpaz force-pushed the gitatributes branch from 27f18a1 to d836106 Compare June 27, 2017 09:29

alcortesm suggested changes Jun 27, 2017

View reviewed changes

dpaz force-pushed the gitatributes branch from d836106 to a34014a Compare June 28, 2017 08:08

abeaumont suggested changes Jun 29, 2017

View reviewed changes

alcortesm approved these changes Jun 29, 2017

View reviewed changes

alcortesm suggested changes Jun 29, 2017

View reviewed changes

dpaz force-pushed the gitatributes branch from 9e2a176 to 0a267e9 Compare July 4, 2017 09:40

alcortesm approved these changes Jul 4, 2017

View reviewed changes

mcarmonaa suggested changes Jul 4, 2017

View reviewed changes

abeaumont reviewed Jul 5, 2017

View reviewed changes

dpaz force-pushed the gitatributes branch 2 times, most recently from 1018320 to 590817f Compare July 13, 2017 07:29

abeaumont suggested changes Jul 14, 2017

View reviewed changes

dpaz added 5 commits July 18, 2017 11:17

Added support for vendor and documentation attributes

5de1f4f

Added support for language attribute

c3ca375

Refactored to be more easily tested

60df022

Now looks if the language is known by enry

04528e0

Changed Matchers from enry- to linguist-

325a91e

dpaz added 3 commits July 18, 2017 11:21

Now a path support multiple types of attributes

33bb157

Updated to the new interface

29dc81f

Changes in the README

8d2a353

dpaz force-pushed the gitatributes branch from 590817f to 8d2a353 Compare July 18, 2017 09:27

mcarmonaa suggested changes Jul 19, 2017

View reviewed changes

Pending changes

11ef5ed

dpaz force-pushed the gitatributes branch from 63bf099 to 11ef5ed Compare July 19, 2017 08:36

abeaumont self-assigned this Jul 19, 2017

vmarkovtsev unassigned abeaumont Jan 31, 2018

6543 mentioned this pull request Jul 27, 2020

Add support for gitattributes go-enry/go-enry#27

Open

		@@ -453,9 +453,11 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {
		// GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes

		@@ -453,9 +453,11 @@ func GetLanguageByAlias(alias string) (lang string, ok bool) {
		// GetLanguagesByGitAttributes returns either a string slice with the lenguage if the filename match with a regExp in .gitattributes
		//or return nil in case of none regexp matchs the filename . It complies with the signature to be a Strategy type.


		const _attrType_name = "vendordocumentationgeneratedlanguage"

		var _attrType_index = [...]uint8{0, 6, 19, 28, 36}

		@@ -139,6 +139,36 @@ Using [linguist/samples](https://github.com/github/linguist/tree/master/samples)
		* all files for SQL language fall to the classifier because we don't parse this [disambiguator expresion](https://github.com/github/linguist/blob/master/lib/linguist/heuristics.rb#L433) for `*.sql` files right. This expression doesn't comply with the pattern for the rest of [heuristics.rb](https://github.com/github/linguist/blob/master/lib/linguist/heuristics.rb) file.


		.gitAttributes

Gitattributes #50

Are you sure you want to change the base?

Gitattributes #50

Conversation

dpaz commented Jun 23, 2017 • edited Loading

smola left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcarmonaa commented Jun 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpaz Jun 27, 2017 • edited Loading

Choose a reason for hiding this comment

abeaumont Jun 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dpaz Jun 27, 2017 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jun 27, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jul 4, 2017 • edited by codecov bot Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abeaumont commented Jul 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abeaumont commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcarmonaa commented Jul 19, 2017

dpaz commented Jul 19, 2017 • edited Loading

abeaumont commented Jul 19, 2017

vmarkovtsev commented Jan 31, 2018

dpaz commented Jun 23, 2017 •

edited

Loading

dpaz Jun 27, 2017 •

edited

Loading

abeaumont Jun 27, 2017 •

edited

Loading

dpaz Jun 27, 2017 •

edited

Loading

codecov bot commented Jun 27, 2017 •

edited

Loading

codecov-io commented Jul 4, 2017 •

edited by codecov bot

Loading

dpaz commented Jul 19, 2017 •

edited

Loading