Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Analysis of Algorithms present in Repository #63

Open
sirjan13 opened this issue Oct 2, 2017 · 5 comments
Open

Add Analysis of Algorithms present in Repository #63

sirjan13 opened this issue Oct 2, 2017 · 5 comments

Comments

@sirjan13
Copy link
Contributor

sirjan13 commented Oct 2, 2017

I have been contributing to this repository and I feel adding Comments mentioning TIme Complexity will be really beneficial for those who would refer to this repository.

Format for adding comments to the respective codes:

Eg:

For Binary Search:-

Time Complexity : O(logn)

@sirjan13
Copy link
Contributor Author

sirjan13 commented Oct 2, 2017

@srbcheema1 it would be great if you could review this and add this under the appropriate labels so that contributors can work towards it.

@srbcheema1
Copy link
Owner

thanks for creating the issue @sirjan13
also i would like to add some rules for codes like code must be modular (functions for different tasks)
and also there should be proper commenting
if there is an alternative way of solving same problem then you can also add all the solutions to a folder
segmented tree problems can be solved with binary indexed tree

@srbcheema1
Copy link
Owner

srbcheema1 commented Oct 2, 2017

@sirjan13
you may provide a set of standard rules to follow to create an analysis

@sirjan13
Copy link
Contributor Author

sirjan13 commented Oct 2, 2017

I Think mentioning Time Complexity is a good way.

@srbcheema1
Copy link
Owner

yupp @sirjan13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants