Skip to content

[Fabric 1.17.1] AppleSkin REI Compat mixin fails to apply #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugeblank opened this issue Oct 8, 2021 · 4 comments
Open

[Fabric 1.17.1] AppleSkin REI Compat mixin fails to apply #144

hugeblank opened this issue Oct 8, 2021 · 4 comments

Comments

@hugeblank
Copy link

hugeblank commented Oct 8, 2021

REI had a major rework recently-ish, causing the compat mixin to crash the client.
Edit: I'm actually not sure this is the case, it looks like method and mixin headers line up, it's probably something more nuanced.

AppleSkin: 2.1.3
REI: 6.0.279-alpha

crash-2021-10-08_16.27.12-client.txt

@hugeblank
Copy link
Author

I should mention that I'm doing all of this in a development environment since that may be relevant. I have appleskin as a jar file in my run/mods folder, and REI as an external library.

squeek502 added a commit that referenced this issue Oct 22, 2021
Depends on Fabric Loader >= 0.12.0 and REI >= 6.0.36-alpha

Fixes #145
Fixes #144
Fixes #132
@squeek502
Copy link
Owner

Try with v2.2.0, that particular compat mixin has been removed.

@squeek502
Copy link
Owner

Also, have you seen this section of the README in the Fabric branch?

https://github.com/squeek502/AppleSkin/tree/1.17-fabric#for-mod-developers

That method of including AppleSkin in your dev environment should be much less error-prone.

@hugeblank
Copy link
Author

Try with v2.2.0, that particular compat mixin has been removed.

Thanks, I'll give it a test when I have time.

That method of including AppleSkin in your dev environment should be much less error-prone.

I could do that as well I suppose. I didn't look into this initially because I don't have any reason to work with the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants