Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more function examples for test suite for postgres #16

Open
MasterOdin opened this issue Aug 9, 2020 · 0 comments
Open

Add more function examples for test suite for postgres #16

MasterOdin opened this issue Aug 9, 2020 · 0 comments

Comments

@MasterOdin
Copy link
Member

As part of the work to add better support for redshift, I had to rewrite the getRoutineCreateScript function to manually construct the create function query, as pg_get_functiondef was added in postgres 8.4. However, the existing test case for that function only tests a simple function without any arguments. Should add a function that has arguments to the test suite to test compliance, and that the query does not break in the future.

@MasterOdin MasterOdin transferred this issue from sqlectron/sqlectron-core Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant