-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with decorate>=5.0.5 in dogpile.cache.region #208
Comments
Hmm, the above patch is breaking tests/cache/test_region.py::AsyncCreatorTest::test_fn_decorator_with_kw, so I would also not exclude the possibility that it's actually the code in openstacksdk that's broken. |
cc @4383 |
any help would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest releases of decorate changed the handling of positional args in some cases, see micheles/decorator@04bb645. This is triggering failures in some consumers, e.g. openstacksdk, see https://storyboard.openstack.org/#!/story/2009114 and micheles/decorator#127. What works for me in local unit testing is adding the kwsyntax=True option like
But maybe there is also a way to adopt to the new behaviour more smoothly. The above patch will break when using an old version of decorate and I don't know whether there's a better solution then wrapping in a try block and repeating the call without the added option if necessary.
The text was updated successfully, but these errors were encountered: