Skip to content

Improve documentation to reveal which artifact provides which configuration property #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghferrari opened this issue Apr 28, 2025 · 3 comments
Assignees
Labels
in: reference documentation Our own reference documentation type: improvement Minor improvements
Milestone

Comments

@ghferrari
Copy link

I'm using Spring Modulith 1.3.5 with Spring Data JPA and postgresql 16. I'm seeing issues with these two settings:

  • spring.modulith.events.jdbc.schema-initialization.enabled
  • spring.modulith.events.jdbc.schema

Neither property appears in Intellij Idea's completion suggestions, which suggests to me they're not defined when Spring Data JPA is in use.

Also, when I try to put Spring Modulith's tables inside a custom database schema named modulith and set spring.modulith.events.jdbc.schema to that value, I see this error:

Schema-validation: missing table [event_publication]

which likewise suggests that Spring Modulith is not using the defined schema value i.e. it's still looking in the public schema rather than the intended modulith schema.

@odrotbohm
Copy link
Member

That's correct, as our JPA integration ends at the JPA level and all database management is handled by your JPA provider or an alternative you configure. Thus, the spring.modulith.events.jdbc properties are only applied if the spring-modulith-events-jdbc module is used.

I'll use this ticket to augment the section of reference documentation listing the properties to include information about which artifact provides the corresponding property.

@odrotbohm odrotbohm self-assigned this Apr 29, 2025
@odrotbohm odrotbohm added in: reference documentation Our own reference documentation type: improvement Minor improvements labels Apr 29, 2025
@odrotbohm odrotbohm changed the title spring.modulith.events.jdbc.* and JPA Improve documentation to reveal which artifact provides which configuration property Apr 29, 2025
@ghferrari
Copy link
Author

ghferrari commented Apr 29, 2025

Thanks @odrotbohm . I'm mainly interested in being able to define a custom schema where the event_publication and event_publication_archive tables will live. Is there a way to configure Spring Modulith to use a custom schema when using JPA?

@odrotbohm
Copy link
Member

You'd need to use the configuration options of your JPA provider (Hibernate?) to achieve that. Note that you can also use the spring-modulith-events-jdbc module with an application that uses JPA as primary persistence mechanism.

@odrotbohm odrotbohm added this to the 1.4 GA milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: reference documentation Our own reference documentation type: improvement Minor improvements
Projects
None yet
Development

No branches or pull requests

2 participants