-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark starter jars as Spring-Boot-Jar-Type: dependencies-starter #195
Labels
Comments
Manifest currently looks like
Current maven plugin configuration <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>${maven-jar-plugin.version}</version>
<configuration>
<archive>
<manifest>
<mainClass>${start-class}</mainClass>
<addDefaultImplementationEntries>true
</addDefaultImplementationEntries>
</manifest>
</archive>
</configuration>
</plugin> Put the configuration in a profile that is active if a property is set and then we'd only have to set that property in the starter poms. Does that sound reasonable @marcingrzejszczak? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add
Spring-Boot-Jar-Type: dependencies-starter
to manifest.spring-projects/spring-boot#22036
spring-projects/spring-boot@fa1d4a4
/cc @wilkinsona
I'm hoping we can configure things here so starter poms have minimal if any changes.
The text was updated successfully, but these errors were encountered: