Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoMethodError on nil.distinct in ProductsFinderDecorator #235

Open
gulzarhussain112 opened this issue Dec 7, 2024 · 0 comments
Open

NoMethodError on nil.distinct in ProductsFinderDecorator #235

gulzarhussain112 opened this issue Dec 7, 2024 · 0 comments

Comments

@gulzarhussain112
Copy link

gulzarhussain112 commented Dec 7, 2024 •
edited
Loading

Description:
The ProductsFinderDecorator in Spree Multi-Vendor causes a NoMethodError when no products are found for the given filters, due to calling distinct on a nil object in the execute method.

Proposed Solution:
This issue is addressed in PR #236, which modifies the execute method in ProductsFinderDecorator to handle nil safely.

References:
PR: #236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gulzarhussain112