Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

All text from the web should use Spree.t() #79

Open
fresh2nd opened this issue Dec 18, 2013 · 1 comment
Open

All text from the web should use Spree.t() #79

fresh2nd opened this issue Dec 18, 2013 · 1 comment

Comments

@fresh2nd
Copy link

I think this is a must in a gem from spree to use the localization. I quote the Internationalization guide:

We strongly urge all extension developers to ensure all customer facing text is rendered via the Spree.t() helper method even if they only include a single default language locale file (as other users can simply include the required YAML file and translations in their site extension).

Its kinda painful to use this theme overriding defaces just to change things to use other languages.

By the way, i think you did a good work with this theme as an example.

@radar
Copy link
Contributor

radar commented Dec 18, 2013

@fresh2nd Please show us what templates are missing the translations. Better still, submit a PR which switches these templates to use the translation helper.

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants