Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Scss variable naming conventions #105

Open
JEphron opened this issue Mar 23, 2014 · 3 comments
Open

Scss variable naming conventions #105

JEphron opened this issue Mar 23, 2014 · 3 comments

Comments

@JEphron
Copy link

JEphron commented Mar 23, 2014

I guess this is a minor cosmetic issue, but I thought it'd be worth bringing up nonetheless.
I noticed that the scss variables are named by color. For example

$c_red:         #e45353

I've overridden them in my project, and now I've got a variable named $c_red that's actually blue. Would it not be better to name them by purpose?

@radar
Copy link
Contributor

radar commented Mar 23, 2014

The comment immediately after that variable definition explains the purpose:

$c_red:         #e45353 !default;  /* Error red      */

As far as I can see, this colour is used for any error dialogs... and imo red is the perfect colour to use for errors, since everywhere else uses it.

Why do you have a red that is blue?

@JEphron
Copy link
Author

JEphron commented Mar 24, 2014

If the sole purpose of that variable is to determine the color of error dialogs, then perhaps it should be named $c_error

There are also $c_blue and $c_orange variables which don't seem to have any specific meaning attached to them.

If this theme is to be easily customizable then the variable names should be flexible enough to avoid confusion.

@radar
Copy link
Contributor

radar commented Apr 3, 2014

@JEphron Could you please submit a PR to give the variables better names?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants