Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a nav link reloads/jumps around the page #64

Open
Erioldoesdesign opened this issue Jul 3, 2023 · 2 comments
Open

Clicking a nav link reloads/jumps around the page #64

Erioldoesdesign opened this issue Jul 3, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Erioldoesdesign
Copy link
Collaborator

Re. Georgia's comment in a PR:

when you click on a menu option, there's a reload/jump that happens that is a bit jarring and the position on the menu doesn't persist to the page loading. Is there anything we can do about that? That seems like a bigger feature/need around maintaining state on load, but also I would think that was a standard feature from the theme?

And Saptak's reply

That is not part of the template. It can definitely be fixed, but needs a localStorage to store the scroll position persistently. I will play around with it in a separate PR.

@Erioldoesdesign Erioldoesdesign added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2023
@Pulkitxm
Copy link

Pulkitxm commented Jul 4, 2023

Can I get assigned? let me know how to start

@Erioldoesdesign Erioldoesdesign removed the good first issue Good for newcomers label Jul 4, 2023
@Erioldoesdesign
Copy link
Collaborator Author

Can I get assigned? let me know how to start

If you have some ideas on how to do this then absolutely open up a PR and It'll get reviewed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants