Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic type annotations #701

Open
wants to merge 14 commits into
base: v3
Choose a base branch
from
Open

Conversation

akathorn
Copy link

@akathorn akathorn commented Jul 1, 2021

All parameters for public methods are annotated.
Methods that return a JSON are annotated with a return type of Dict[str, Any], which is quite limited.

This is part of #439.

@akathorn akathorn changed the title Add type annotations Add basic type annotations Jul 1, 2021
@stephanebruckert
Copy link
Member

Since python3.5 is EOL, I suggest you can just remove it from

https://github.com/plamere/spotipy/blob/07fec53288bd097576637d922865b3900e703952/.github/workflows/pythonapp.yml#L11

@stephanebruckert
Copy link
Member

@akathorn I'm happy to merge this, any chance you can go through the conflicting files (today the v3 branch is synced)? Thanks!

@akathorn
Copy link
Author

I didn't really wrap this up. I'll explain on #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants