Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor trap #1146

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: refactor trap #1146

merged 1 commit into from
Jan 13, 2025

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Jan 7, 2025 •
edited
Loading

Description

Refactor trap method.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Refactor/improvement

How Has This Been Tested?

manual, unit, integration

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ajasnosz ajasnosz marked this pull request as ready for review January 9, 2025 09:09
@ajasnosz ajasnosz merged commit c60dbad into develop Jan 13, 2025
12 checks passed
@ajasnosz ajasnosz deleted the fix/refactor-trap branch January 13, 2025 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.12.1-beta.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikheifets-splunk ikheifets-splunk ikheifets-splunk approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajasnosz @srv-rr-github-token @ikheifets-splunk