Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use JVM default truststore #435

Closed
notizklotz opened this issue Jun 19, 2024 · 1 comment
Closed

Allow to use JVM default truststore #435

notizklotz opened this issue Jun 19, 2024 · 1 comment

Comments

@notizklotz
Copy link

It seems that with the default splunk.hec.ssl.validate.certs=true one must configure a custom truststore path and it's not possible to use the JVM default truststore.

I think the config validation here is too strict: https://github.com/splunk/kafka-connect-splunk/blob/release-2.2.2/src/main/java/com/splunk/kafka/connect/SplunkSinkConnectorConfig.java#L540

The code actually creating the httpClient would handle the case alright without modifications: https://github.com/splunk/kafka-connect-splunk/blob/release-2.2.2/src/main/java/com/splunk/hecclient/Hec.java#L279

@notizklotz
Copy link
Author

Duplicate of #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant