Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy related configurations for splunk connector config #434

Open
wangshu3000 opened this issue May 28, 2024 · 2 comments
Open

Add proxy related configurations for splunk connector config #434

wangshu3000 opened this issue May 28, 2024 · 2 comments

Comments

@wangshu3000
Copy link

wangshu3000 commented May 28, 2024

Problem:

Current Splunk connector doesn't have proxy related settings, that means the connector cannot connect to HEC endpoint via a proxy configured at connector level.

For some cases, to connect to splunk cloud HEC endpoint will need to go through a dedicated outbound proxy. It could be a different proxy than other connectors.

It's not supported to configure a connector level proxy via the rest configuration api.
Configure the proxy via JVM OPTS will impact all other connectors running on the same cluster.

So provide proxy related settings via rest api or connector properties would be necessary.

Many other http based connectors also have this feature.
For example: http connector, S3 connector, SQS connector etc.

Solution:

  1. Add proxy settings to SplunkSinkConnecorConfig.java so that we can configure the connector's proxy via api or connect properties file. The new configurations will be together with the existing httpKeepAlive config.
  2. Add proxy settings to RequestConfig in HttpClientBuilder.java file if the proxy settings were configured.
  3. Other dependencies files and Test files etc.
  4. Update README.md file
  5. Update latest coverage report.

I would like to work on this and contribute a PR once i finish it.

@OM-HASE
Copy link

OM-HASE commented May 30, 2024

@wangshu3000
Could you please assign this issue to me? I would be very grateful for the opportunity to contribute.
Thank you!

@wangshu3000
Copy link
Author

wangshu3000 commented May 31, 2024

@OM-HASE Thanks for your interests. Looks like this is a feature we all desire. but i'm sorry to say that I have finished the changes and reviewing it, once it's all done i'll push to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants