Skip to content

Commit ae70b2f

Browse files
spiralbotspiralbot
committed
refactor: enable phpunit code quality set for rector (#1186)
1 parent fc7e094 commit ae70b2f

17 files changed

+289
-301
lines changed

‎tests/AcceptHeaderItemTest.php

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class AcceptHeaderItemTest extends TestCase
1414
#[DataProvider('emptyItemProvider')]
1515
public function testEmptyItem(AcceptHeaderItem $item): void
1616
{
17-
$this->assertEmpty($item->getValue());
18-
$this->assertEquals('', (string)$item);
17+
self::assertEmpty($item->getValue());
18+
self::assertSame('', (string)$item);
1919
}
2020

2121
public static function emptyItemProvider(): iterable
@@ -34,17 +34,17 @@ public static function emptyItemProvider(): iterable
3434
public function testValue(string $value): void
3535
{
3636
$item = AcceptHeaderItem::fromString($value);
37-
$this->assertEquals($value, $item->getValue());
37+
self::assertSame($value, $item->getValue());
3838

3939
$acceptHeader = new AcceptHeader([$item]);
40-
$this->assertCount(1, $acceptHeader->getAll());
40+
self::assertCount(1, $acceptHeader->getAll());
4141

4242
$item = AcceptHeaderItem::fromString(" $value ");
43-
$this->assertEquals($value, $item->getValue());
43+
self::assertSame($value, $item->getValue());
4444

4545
$acceptHeader = new AcceptHeader([$item]);
46-
$this->assertCount(1, $acceptHeader->getAll());
47-
$this->assertEquals($value, (string)$acceptHeader->getAll()[0]);
46+
self::assertCount(1, $acceptHeader->getAll());
47+
self::assertSame($value, (string)$acceptHeader->getAll()[0]);
4848
}
4949

5050
public static function valueProvider(): \Traversable
@@ -59,15 +59,15 @@ public static function valueProvider(): \Traversable
5959
public function testItemQualityBoundaries(float $quality, AcceptHeaderItem $item): void
6060
{
6161
if ($quality > 1) {
62-
$this->assertSame(1.0, $item->getQuality());
62+
self::assertEqualsWithDelta(1.0, $item->getQuality(), PHP_FLOAT_EPSILON);
6363
}
6464

6565
if ($quality < 0) {
66-
$this->assertSame(0.0, $item->getQuality());
66+
self::assertEqualsWithDelta(0.0, $item->getQuality(), PHP_FLOAT_EPSILON);
6767
}
6868

69-
$this->assertGreaterThanOrEqual(0, $item->getQuality());
70-
$this->assertLessThanOrEqual(1, $item->getQuality());
69+
self::assertGreaterThanOrEqual(0, $item->getQuality());
70+
self::assertLessThanOrEqual(1, $item->getQuality());
7171
}
7272

7373
public static function qualityBoundariesProvider(): iterable
@@ -86,7 +86,7 @@ public static function qualityBoundariesProvider(): iterable
8686
#[DataProvider('paramsProvider')]
8787
public function testParams(array $params, AcceptHeaderItem $item): void
8888
{
89-
$this->assertSame($params, $item->getParams());
89+
self::assertSame($params, $item->getParams());
9090
}
9191

9292
public static function paramsProvider(): iterable
@@ -132,7 +132,7 @@ public static function paramsProvider(): iterable
132132
#[DataProvider('itemProvider')]
133133
public function testItem(string $expected, AcceptHeaderItem $item): void
134134
{
135-
$this->assertSame($expected, (string)$item);
135+
self::assertSame($expected, (string)$item);
136136
}
137137

138138
public static function itemProvider(): iterable

‎tests/AcceptHeaderTest.php

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@ public function testEmpty(): void
1919
(new AcceptHeaderItem('*/*'))->withValue('')
2020
]);
2121

22-
$this->assertCount(0, $header->getAll());
23-
$this->assertSame('', (string)$header);
22+
self::assertCount(0, $header->getAll());
23+
self::assertSame('', (string)$header);
2424
}
2525

2626
public function testHeaderSanitize(): void
2727
{
2828
$headers = AcceptHeader::fromString('text/*, text/html, ,;,text/html;level=1, */*')->getAll();
2929

30-
$this->assertCount(3, $headers);
31-
$this->assertSame('text/html', $headers[0]->getValue());
32-
$this->assertSame('text/*', $headers[1]->getValue());
33-
$this->assertSame('*/*', $headers[2]->getValue());
30+
self::assertCount(3, $headers);
31+
self::assertSame('text/html', $headers[0]->getValue());
32+
self::assertSame('text/*', $headers[1]->getValue());
33+
self::assertSame('*/*', $headers[2]->getValue());
3434
}
3535

3636
public function testImmutability(): void
@@ -40,17 +40,17 @@ public function testImmutability(): void
4040
$header = new AcceptHeader([$firstItem]);
4141
$firstItem->withValue('text/html');
4242

43-
$this->assertSame('*/*', $header->add($secondItem)->getAll()[0]->getValue());
43+
self::assertSame('*/*', $header->add($secondItem)->getAll()[0]->getValue());
4444
}
4545

4646
#[DataProvider('sameQualityCompareProvider')]
4747
public function testCompareWithEqualQuality(string $input, string $a, string $b): void
4848
{
4949
$headers = AcceptHeader::fromString($input)->getAll();
5050

51-
$this->assertCount(2, $headers);
52-
$this->assertEquals($a, $headers[0]->getValue());
53-
$this->assertEquals($b, $headers[1]->getValue());
51+
self::assertCount(2, $headers);
52+
self::assertEquals($a, $headers[0]->getValue());
53+
self::assertEquals($b, $headers[1]->getValue());
5454
}
5555

5656
public static function sameQualityCompareProvider(): \Traversable
@@ -64,20 +64,20 @@ public static function sameQualityCompareProvider(): \Traversable
6464
public function testDuplicatedItems(): void
6565
{
6666
$header = AcceptHeader::fromString('*/*;q=0.9,text/html,*/*');
67-
$this->assertSame('text/html, */*', (string)$header);
67+
self::assertSame('text/html, */*', (string)$header);
6868

6969
$header = AcceptHeader::fromString('text/html;q=0.4,*/*;q=0.9,text/html;q=0.6');
70-
$this->assertSame('*/*; q=0.9, text/html; q=0.6', (string)$header);
70+
self::assertSame('*/*; q=0.9, text/html; q=0.6', (string)$header);
7171
}
7272

7373
public function testAccessor(): void
7474
{
7575
$acceptHeader = AcceptHeader::fromString('text/css;q=0.3, text/html;q=0.3');
76-
$this->assertTrue($acceptHeader->has('tExt/css '));
77-
$this->assertFalse($acceptHeader->has('tExt/javascript'));
76+
self::assertTrue($acceptHeader->has('tExt/css '));
77+
self::assertFalse($acceptHeader->has('tExt/javascript'));
7878

79-
$this->assertSame('text/css; q=0.3', (string)$acceptHeader->get('text/css'));
80-
$this->assertSame('text/html; q=0.3', (string)$acceptHeader->get('text/html'));
79+
self::assertSame('text/css; q=0.3', (string)$acceptHeader->get('text/css'));
80+
self::assertSame('text/html; q=0.3', (string)$acceptHeader->get('text/html'));
8181
}
8282

8383
#[DataProvider('addAndSortProvider')]
@@ -87,10 +87,10 @@ public function testAddAndSort(string $items, string $item, array $expected): vo
8787
$acceptHeader = $acceptHeader->add($item);
8888

8989
$headers = $acceptHeader->getAll();
90-
$this->assertCount(count($expected), $headers);
90+
self::assertCount(count($expected), $headers);
9191

9292
foreach ($expected as $i => $value) {
93-
$this->assertSame($value, $headers[$i]->getValue());
93+
self::assertSame($value, $headers[$i]->getValue());
9494
}
9595
}
9696

@@ -124,10 +124,10 @@ public function testCompare(string $items, array $expected): void
124124
$acceptHeader = AcceptHeader::fromString($items);
125125

126126
$headers = $acceptHeader->getAll();
127-
$this->assertCount(count($expected), $headers);
127+
self::assertCount(count($expected), $headers);
128128

129129
foreach ($expected as $i => $value) {
130-
$this->assertSame($value, (string)$headers[$i]);
130+
self::assertSame($value, (string)$headers[$i]);
131131
}
132132
}
133133

‎tests/ConfigTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public function testBasePath(): void
1919
'basePath' => '/'
2020
]);
2121

22-
$this->assertSame('/', $c->getBasePath());
22+
self::assertSame('/', $c->getBasePath());
2323
}
2424

2525
public function testBaseHeaders(): void
@@ -30,7 +30,7 @@ public function testBaseHeaders(): void
3030
]
3131
]);
3232

33-
$this->assertSame(['key' => 'value'], $c->getBaseHeaders());
33+
self::assertSame(['key' => 'value'], $c->getBaseHeaders());
3434
}
3535

3636
public function testBaseMiddleware(): void
@@ -39,6 +39,6 @@ public function testBaseMiddleware(): void
3939
'middleware' => [TestMiddleware::class]
4040
]);
4141

42-
$this->assertSame([TestMiddleware::class], $c->getMiddleware());
42+
self::assertSame([TestMiddleware::class], $c->getMiddleware());
4343
}
4444
}

‎tests/ExceptionsTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,43 +18,43 @@ class ExceptionsTest extends TestCase
1818
public function testClientException(): void
1919
{
2020
$e = new ClientException();
21-
$this->assertSame(400, $e->getCode());
21+
self::assertSame(400, $e->getCode());
2222
}
2323

2424
public function testNotFound(): void
2525
{
2626
$e = new NotFoundException();
27-
$this->assertSame(404, $e->getCode());
27+
self::assertSame(404, $e->getCode());
2828
}
2929

3030
public function testBadRequest(): void
3131
{
3232
$e = new BadRequestException();
33-
$this->assertSame(400, $e->getCode());
33+
self::assertSame(400, $e->getCode());
3434
}
3535

3636
public function testForbidden(): void
3737
{
3838
$e = new ForbiddenException();
39-
$this->assertSame(403, $e->getCode());
39+
self::assertSame(403, $e->getCode());
4040
}
4141

4242
public function testUnauthorized(): void
4343
{
4444
$e = new UnauthorizedException();
45-
$this->assertSame(401, $e->getCode());
45+
self::assertSame(401, $e->getCode());
4646
}
4747

4848
public function testServerError(): void
4949
{
5050
$e = new ClientException\ServerErrorException();
51-
$this->assertSame(500, $e->getCode());
51+
self::assertSame(500, $e->getCode());
5252
}
5353

5454
#[DataProvider('allExceptionsWithPreviousSet')]
5555
public function testPreviousSetter(\Throwable $exception): void
5656
{
57-
$this->assertInstanceOf(\Throwable::class, $exception->getPrevious());
57+
self::assertInstanceOf(\Throwable::class, $exception->getPrevious());
5858
}
5959

6060
public static function allExceptionsWithPreviousSet(): \Generator

‎tests/FilesTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ public function testShortcut(): void
3838

3939
$this->container->bind(ServerRequestInterface::class, $request);
4040

41-
$this->assertInstanceOf(UploadedFileInterface::class, $this->input->file('file'));
42-
$this->assertSame(null, $this->input->file('other'));
41+
self::assertInstanceOf(UploadedFileInterface::class, $this->input->file('file'));
42+
self::assertNull($this->input->file('other'));
4343
}
4444

4545
public function testGetFilename(): void
@@ -58,9 +58,9 @@ public function testGetFilename(): void
5858

5959

6060
$filename = $this->input->files->getFilename('file');
61-
$this->assertTrue(file_exists($filename));
61+
self::assertFileExists($filename);
6262

63-
$this->assertSame(file_get_contents(__FILE__), file_get_contents($filename));
63+
self::assertSame(file_get_contents(__FILE__), file_get_contents($filename));
6464
}
6565

6666

@@ -79,6 +79,6 @@ public function testGetFilenameMissing(): void
7979
$this->container->bind(ServerRequestInterface::class, $request);
8080

8181
$filename = $this->input->files->getFilename('file2');
82-
$this->assertNull($filename);
82+
self::assertNull($filename);
8383
}
8484
}

‎tests/HeadersTest.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function testShortcut(): void
2929
$request = $request->withAddedHeader('Path', 'value');
3030
$this->container->bind(ServerRequestInterface::class, $request);
3131

32-
$this->assertSame('value', $this->input->header('path'));
32+
self::assertSame('value', $this->input->header('path'));
3333
}
3434

3535
public function testHas(): void
@@ -39,8 +39,8 @@ public function testHas(): void
3939
$request = $request->withAddedHeader('Path', 'value');
4040
$this->container->bind(ServerRequestInterface::class, $request);
4141

42-
$this->assertTrue($this->input->headers->has('path'));
43-
$this->assertTrue($this->input->headers->has('Path'));
42+
self::assertTrue($this->input->headers->has('path'));
43+
self::assertTrue($this->input->headers->has('Path'));
4444
}
4545

4646
public function testFetch(): void
@@ -51,7 +51,7 @@ public function testFetch(): void
5151
$request = $request->withAddedHeader('Path', 'value2');
5252
$this->container->bind(ServerRequestInterface::class, $request);
5353

54-
$this->assertSame([
54+
self::assertSame([
5555
'Path' => 'value,value2'
5656
], $this->input->headers->fetch(['path']));
5757
}
@@ -64,13 +64,10 @@ public function testFetchNoImplode(): void
6464
$request = $request->withAddedHeader('Path', 'value2');
6565
$this->container->bind(ServerRequestInterface::class, $request);
6666

67-
$this->assertSame([
67+
self::assertSame([
6868
'Path' => ['value', 'value2']
6969
], $this->input->headers->fetch(['path'], false, true, null));
7070

71-
$this->assertSame(
72-
['value', 'value2'],
73-
$this->input->headers->get('path', null, false)
74-
);
71+
self::assertSame(['value', 'value2'], $this->input->headers->get('path', null, false));
7572
}
7673
}

0 commit comments

Comments
 (0)