refactor: Add ArrowFunction return type #1183

Author: spiralbot

src/Header/AcceptHeader.php

@@ -78,7 +78,7 @@ public function getAll(): array
             /**
              * Sort item in descending order.
              */
-            \uasort($this->items, static fn (AcceptHeaderItem $a, AcceptHeaderItem $b) => self::compare($a, $b) * -1);
+            \uasort($this->items, static fn (AcceptHeaderItem $a, AcceptHeaderItem $b): int => self::compare($a, $b) * -1);
 
             $this->sorted = true;
         }

tests/HttpTest.php

@@ -47,7 +47,7 @@ public function testRunHandler(): void
     {
         $core = $this->getCore();
 
-        $core->setHandler(fn() => 'hello world');
+        $core->setHandler(fn(): string => 'hello world');
 
         $response = $core->handle(new ServerRequest('GET', ''));
         $this->assertSame('hello world', (string)$response->getBody());
@@ -67,7 +67,7 @@ public function testHandlerInterface(): void
     {
         $core = $this->getCore();
         $core->setHandler(
-            new CallableHandler(fn() => 'hello world', new ResponseFactory(new HttpConfig(['headers' => []])))
+            new CallableHandler(fn(): string => 'hello world', new ResponseFactory(new HttpConfig(['headers' => []])))
         );
 
         $response = $core->handle(new ServerRequest('GET', ''));
@@ -143,7 +143,7 @@ public function testJson(): void
     {
         $core = $this->getCore();
 
-        $core->setHandler(fn() => [
+        $core->setHandler(fn(): array => [
             'status' => 404,
             'message' => 'not found',
         ]);
@@ -157,7 +157,7 @@ public function testJsonSerializable(): void
     {
         $core = $this->getCore();
 
-        $core->setHandler(fn() => new Json([
+        $core->setHandler(fn(): Json => new Json([
             'status' => 404,
             'message' => 'not found',
         ]));
@@ -171,7 +171,7 @@ public function testMiddleware(): void
     {
         $core = $this->getCore([HeaderMiddleware::class]);
 
-        $core->setHandler(fn() => 'hello?');
+        $core->setHandler(fn(): string => 'hello?');
 
         $response = $core->handle(new ServerRequest('GET', ''));
         $this->assertSame(['text/html; charset=UTF-8'], $response->getHeader('Content-Type'));
@@ -186,7 +186,7 @@ public function testMiddlewareTrait(): void
         $core->getPipeline()->pushMiddleware(new Header2Middleware());
         $core->getPipeline()->riseMiddleware(new HeaderMiddleware());
 
-        $core->setHandler(fn() => 'hello?');
+        $core->setHandler(fn(): string => 'hello?');
 
         $response = $core->handle(new ServerRequest('GET', ''));
         $this->assertSame(['text/html; charset=UTF-8'], $response->getHeader('Content-Type'));
@@ -201,7 +201,7 @@ public function testMiddlewareTraitReversed(): void
         $core->getPipeline()->pushMiddleware(new HeaderMiddleware());
         $core->getPipeline()->riseMiddleware(new Header2Middleware());
 
-        $core->setHandler(fn() => 'hello?');
+        $core->setHandler(fn(): string => 'hello?');
 
         $response = $core->handle(new ServerRequest('GET', ''));
         $this->assertSame(['text/html; charset=UTF-8'], $response->getHeader('Content-Type'));
@@ -237,7 +237,7 @@ public function testEventsShouldBeDispatched(): void
 
         $core = $this->getCore();
 
-        $core->setHandler(fn() => 'hello world');
+        $core->setHandler(fn(): string => 'hello world');
 
         $response = $core->handle($request);
         $this->assertSame('hello world', (string)$response->getBody());
@@ -256,7 +256,7 @@ public function testPassingTracerIntoScope(): void
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(fn() => 'hello world');
+        $http->setHandler(fn(): string => 'hello world');
 
         $tracerFactory
             ->shouldReceive('make')
@@ -319,7 +319,7 @@ function ($name, $callback, $attributes, $scoped, $traceKind) {
             $tracerFactory,
         );
 
-        $http->setHandler(fn() => 'hello world');
+        $http->setHandler(fn(): string => 'hello world');
 
         $response = $http->handle($request);
         $this->assertSame('hello world', (string)$response->getBody());
@@ -338,7 +338,7 @@ public function testTraceContextIsAppliedToResponse(): void
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(fn() => 'hello world');
+        $http->setHandler(fn(): string => 'hello world');
 
         $tracerFactory
             ->shouldReceive('make')

tests/PipelineTest.php

@@ -28,7 +28,7 @@ public function testTarget(): void
     {
         $pipeline = new Pipeline($this->container);
 
-        $handler = new CallableHandler(fn() => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
+        $handler = new CallableHandler(fn(): string => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
 
         $response = $pipeline->withHandler($handler)->handle(new ServerRequest('GET', ''));
 
@@ -41,7 +41,7 @@ public function testHandle(): void
     {
         $pipeline = new Pipeline($this->container);
 
-        $handler = new CallableHandler(fn() => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
+        $handler = new CallableHandler(fn(): string => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
 
         $response = $pipeline->process(new ServerRequest('GET', ''), $handler);
 
@@ -67,7 +67,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             }
         };
         $request = new ServerRequest('GET', '');
-        $handler = new CallableHandler(fn() => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
+        $handler = new CallableHandler(fn(): string => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
 
         $dispatcher = $this->createMock(EventDispatcherInterface::class);
         $dispatcher
@@ -87,7 +87,7 @@ public function testRequestResetThroughPipeline(): void
         $this->container->getBinder('http')
             ->bindSingleton(CurrentRequest::class, new CurrentRequest());
         $this->container->getBinder('http')
-            ->bind(ServerRequestInterface::class, static fn(CurrentRequest $cr) => $cr->get());
+            ->bind(ServerRequestInterface::class, static fn(CurrentRequest $cr): ?ServerRequestInterface => $cr->get());
 
         $middleware = new class implements MiddlewareInterface {
             public function process(
@@ -109,7 +109,7 @@ public function process(
             new \Spiral\Core\Scope(name: 'http'),
             function (ScopeInterface $c) use ($middleware): void {
                 $request = new ServerRequest('GET', '');
-                $handler = new CallableHandler(fn() => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
+                $handler = new CallableHandler(fn(): string => 'response', new ResponseFactory(new HttpConfig(['headers' => []])));
 
                 $pipeline = new Pipeline($c, null, new NullTracer($c));