diff --git a/packages/core/src/pipeline/details/StageFailureMessage.tsx b/packages/core/src/pipeline/details/StageFailureMessage.tsx index ef04549f858..3368fd1c93c 100644 --- a/packages/core/src/pipeline/details/StageFailureMessage.tsx +++ b/packages/core/src/pipeline/details/StageFailureMessage.tsx @@ -73,33 +73,19 @@ export class StageFailureMessage extends React.Component 0) { + if (isFailed || failedTask || message || messages.length) { const exceptionTitle = isFailed ? (messages.length ? 'Exceptions' : 'Exception') : 'Warning'; - - // expression evaluation warnings can get really long and hide actual failure messages, source - // filter out expression evaluation failure messages if either: - // - there was a stage failure (and failed expressions don't fail the stage) - // - expression evaluation was explicitly disabled for the stage(as Orca still processes expressions and populates - // warnings when evaluation is disabled disabled) - const shouldFilterExpressionFailures = - (isFailed && !stage.context?.failOnFailedExpressions) || stage.context?.skipExpressionEvaluation; - - if (shouldFilterExpressionFailures) { - stageMessages = stageMessages.filter((m) => !m.startsWith('Failed to evaluate')); - - if (stageMessages.length === 0) { - // no messages to be displayed after filtering - return null; - } - } - - const displayMessages = stageMessages.map((m, i) => ( - - )); + const displayMessages = + message || !messages.length ? ( + + ) : ( + messages.map((m, i) => ( + + )) + ); if (displayMessages) { return (