Dev/lint (#7)

* Setting up code formatter * Apply prettier * Set up lint * Apply lint
spectral-lab · May 30, 2019 · 4fb4e02 · 4fb4e02
1 parent d008d4d
commit 4fb4e02
Show file tree

Hide file tree

Showing 12 changed files with 1,023 additions and 125 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.eslintrc b/.eslintrc
@@ -0,0 +1,32 @@
+{
+  "env": {
+    "es6": true,
+    "node": true
+  },
+  "parser": "babel-eslint",
+  "extends": ["eslint:recommended", "plugin:prettier/recommended"],
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
+  "plugins": ["prettier"],
+  "rules": {
+    "no-console": "off",
+    "prettier/prettier": "error"
+  },
+  "overrides": [
+    {
+      "files": "**/js-index.js",
+      "env": {
+        "es6": false,
+        "node": false
+      },
+      "parserOptions": {
+        "ecmaVersion": 5
+      },
+      "rules": {
+        "no-undef": "off",
+        "no-unused-vars": "off"
+      }
+    }
+  ]
+}
diff --git a/.prettierrc.js b/.prettierrc.js
@@ -0,0 +1,7 @@
+module.exports = {
+  "trailingComma": "none",
+  "tabWidth": 2,
+  "semi": true,
+  "singleQuote": true,
+  "arrowParens": "always"
+};
diff --git a/package.json b/package.json
@@ -3,15 +3,23 @@
   "version": "1.0.0",
   "description": "Max for Live devices for utilizing MPE",
   "scripts": {
+    "format": "yarn prettier --write **/*.js",
+    "lint": "yarn eslint .",
+    "lint:fix": "yarn eslint . --fix",
     "rm-cache": "node ./scripts/rm-cache"
   },
   "main": "index.js",
   "repository": "https://github.com/spectral-lab/m4l-mpe-tools",
   "author": "spectral-lab",
   "license": "MIT",
   "devDependencies": {
+    "babel-eslint": "^10.0.1",
     "chai": "^4.2.0",
+    "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
+    "eslint-plugin-prettier": "^3.1.0",
     "note-parser": "^2.0.1",
+    "prettier": "^1.17.1",
     "rimraf": "^2.6.3"
   },
   "dependencies": {

diff --git a/projects/mpe_out/code/js-index.js b/projects/mpe_out/code/js-index.js
@@ -1,30 +1,27 @@
 // @ts-nocheck
 
 var console = {
-	log: function () {
-		for(var i=0,len=arguments.length; i<len; i++) {
-			var message = arguments[i];
-			if(message && message.toString) {
-				var s = message.toString();
-				if(s.indexOf("[object ") >= 0) {
-					s = JSON.stringify(message);
-				}
-				post(s);
-			}
-			else if(message === null) {
-				post("<null>");
-			}
-			else {
-				post(message);
-			}
-		}
-		post("\n");
-	}
-}
+  log: function() {
+    for (var i = 0, len = arguments.length; i < len; i++) {
+      var message = arguments[i];
+      if (message && message.toString) {
+        var s = message.toString();
+        if (s.indexOf('[object ') >= 0) {
+          s = JSON.stringify(message);
+        }
+        post(s);
+      } else if (message === null) {
+        post('<null>');
+      } else {
+        post(message);
+      }
+    }
+    post('\n');
+  }
+};
 
-function get_track_id(){
-	var thisTrack = new LiveAPI('this_device canonical_parent');
-	console.log("current track id:", thisTrack.id);
-	outlet(0, 'track_id', thisTrack.id);
+function get_track_id() {
+  var thisTrack = new LiveAPI('this_device canonical_parent');
+  console.log('current track id:', thisTrack.id);
+  outlet(0, 'track_id', thisTrack.id);
 }
-
diff --git a/projects/mpe_out/node_content/main.js b/projects/mpe_out/node_content/main.js
@@ -8,11 +8,11 @@ const main = () => {
   maxAPI.addHandler('send-midi', sendMIDI);
   output.openPort(0);
   updateMenu();
-}
+};
 
 const updateMenu = () => {
   maxAPI.outlet('to-menu', 'clear');
-  for (let i = 0; i < output.getPortCount(); i ++) {
+  for (let i = 0; i < output.getPortCount(); i++) {
     maxAPI.outlet('to-menu', 'append', output.getPortName(i));
   }
 };
@@ -35,8 +35,7 @@ const sendMIDI = (status, data1, data2) => {
     output.sendMessage([status]);
     return;
   }
-  maxAPI.post('Append MIDI message as a list of integers')
+  maxAPI.post('Append MIDI message as a list of integers');
 };
 
 main();
-
diff --git a/projects/mpe_player/code/js-index.js b/projects/mpe_player/code/js-index.js
@@ -1,30 +1,27 @@
 // @ts-nocheck
 
 var console = {
-	log: function () {
-		for(var i=0,len=arguments.length; i<len; i++) {
-			var message = arguments[i];
-			if(message && message.toString) {
-				var s = message.toString();
-				if(s.indexOf("[object ") >= 0) {
-					s = JSON.stringify(message);
-				}
-				post(s);
-			}
-			else if(message === null) {
-				post("<null>");
-			}
-			else {
-				post(message);
-			}
-		}
-		post("\n");
-	}
-}
+  log: function() {
+    for (var i = 0, len = arguments.length; i < len; i++) {
+      var message = arguments[i];
+      if (message && message.toString) {
+        var s = message.toString();
+        if (s.indexOf('[object ') >= 0) {
+          s = JSON.stringify(message);
+        }
+        post(s);
+      } else if (message === null) {
+        post('<null>');
+      } else {
+        post(message);
+      }
+    }
+    post('\n');
+  }
+};
 
-function get_track_id(){
-	var thisTrack = new LiveAPI('this_device canonical_parent');
-	console.log("current track id:", thisTrack.id);
-	outlet(0, 'track_id', thisTrack.id);
+function get_track_id() {
+  var thisTrack = new LiveAPI('this_device canonical_parent');
+  console.log('current track id:', thisTrack.id);
+  outlet(0, 'track_id', thisTrack.id);
 }
-
diff --git a/projects/poly_oscillator/code/js-index.js b/projects/poly_oscillator/code/js-index.js
@@ -1,30 +1,27 @@
 // @ts-nocheck
 
 var console = {
-	log: function () {
-		for(var i=0,len=arguments.length; i<len; i++) {
-			var message = arguments[i];
-			if(message && message.toString) {
-				var s = message.toString();
-				if(s.indexOf("[object ") >= 0) {
-					s = JSON.stringify(message);
-				}
-				post(s);
-			}
-			else if(message === null) {
-				post("<null>");
-			}
-			else {
-				post(message);
-			}
-		}
-		post("\n");
-	}
-}
+  log: function() {
+    for (var i = 0, len = arguments.length; i < len; i++) {
+      var message = arguments[i];
+      if (message && message.toString) {
+        var s = message.toString();
+        if (s.indexOf('[object ') >= 0) {
+          s = JSON.stringify(message);
+        }
+        post(s);
+      } else if (message === null) {
+        post('<null>');
+      } else {
+        post(message);
+      }
+    }
+    post('\n');
+  }
+};
 
-function get_track_id(){
-	var thisTrack = new LiveAPI('this_device canonical_parent');
-	console.log("current track id:", thisTrack.id);
-	outlet(0, 'track_id', thisTrack.id);
+function get_track_id() {
+  var thisTrack = new LiveAPI('this_device canonical_parent');
+  console.log('current track id:', thisTrack.id);
+  outlet(0, 'track_id', thisTrack.id);
 }
-
diff --git a/projects/test/code/convert_nn_to_freq.test.js b/projects/test/code/convert_nn_to_freq.test.js
@@ -5,29 +5,55 @@ const parser = require('note-parser');
 module.exports = {
   target: 'convert_nn_to_freq',
   initPatcher: function*(maxAPI) {
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 69, 'inlet1':8192, 'inlet2':2 } });
+    maxAPI.outlet({
+      convert_nn_to_freq: { inlet0: 69, inlet1: 8192, inlet2: 2 }
+    });
     assert.notEqual(yield, null, 'isOk');
   },
   testNoBend: function*(maxAPI) {
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 60 } });
+    maxAPI.outlet({ convert_nn_to_freq: { inlet0: 60 } });
     expect(yield, 'Do nothing on C=60').to.be.closeTo(parser.freq(60), 0.1);
   },
   testBendUpToTheEnd: function*(maxAPI) {
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 62, 'inlet1':16383 } });
-    expect(yield, 'Bend up from D=62 to E=64').to.be.closeTo(parser.freq(64), 0.1);
+    maxAPI.outlet({ convert_nn_to_freq: { inlet0: 62, inlet1: 16383 } });
+    expect(yield, 'Bend up from D=62 to E=64').to.be.closeTo(
+      parser.freq(64),
+      0.1
+    );
   },
   testBendDownToTheEnd: function*(maxAPI) {
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 65, 'inlet1':0 } });
-    expect(yield, 'Bend down from F=65 to Eb=63').to.be.closeTo(parser.freq(63), 0.1);
+    maxAPI.outlet({ convert_nn_to_freq: { inlet0: 65, inlet1: 0 } });
+    expect(yield, 'Bend down from F=65 to Eb=63').to.be.closeTo(
+      parser.freq(63),
+      0.1
+    );
   },
   testBendWithRange8: function*(maxAPI) {
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 48, 'inlet1':16383, 'inlet2': 8 } });
-    expect(yield, 'Bend up from C=48 to Ab=56').to.be.closeTo(parser.freq(56), 0.1);
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 48, 'inlet1':0, 'inlet2': 8 } });
-    expect(yield, 'Bend down from C=48 to E=40').to.be.closeTo(parser.freq(40), 0.1);
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 48, 'inlet1':12288, 'inlet2': 8 } });
-    expect(yield, 'Bend up from C=48 to E=52').to.be.closeTo(parser.freq(52), 0.1);
-    maxAPI.outlet({ convert_nn_to_freq: { 'inlet0': 48, 'inlet1':4096, 'inlet2': 8 } });
-    expect(yield, 'Bend down from C=48 to Ab=44').to.be.closeTo(parser.freq(44), 0.1);
+    maxAPI.outlet({
+      convert_nn_to_freq: { inlet0: 48, inlet1: 16383, inlet2: 8 }
+    });
+    expect(yield, 'Bend up from C=48 to Ab=56').to.be.closeTo(
+      parser.freq(56),
+      0.1
+    );
+    maxAPI.outlet({ convert_nn_to_freq: { inlet0: 48, inlet1: 0, inlet2: 8 } });
+    expect(yield, 'Bend down from C=48 to E=40').to.be.closeTo(
+      parser.freq(40),
+      0.1
+    );
+    maxAPI.outlet({
+      convert_nn_to_freq: { inlet0: 48, inlet1: 12288, inlet2: 8 }
+    });
+    expect(yield, 'Bend up from C=48 to E=52').to.be.closeTo(
+      parser.freq(52),
+      0.1
+    );
+    maxAPI.outlet({
+      convert_nn_to_freq: { inlet0: 48, inlet1: 4096, inlet2: 8 }
+    });
+    expect(yield, 'Bend down from C=48 to Ab=44').to.be.closeTo(
+      parser.freq(44),
+      0.1
+    );
   }
-};
+};
diff --git a/projects/vst_loader/code/js-index.js b/projects/vst_loader/code/js-index.js
@@ -1,30 +1,27 @@
 // @ts-nocheck
 
 var console = {
-	log: function () {
-		for(var i=0,len=arguments.length; i<len; i++) {
-			var message = arguments[i];
-			if(message && message.toString) {
-				var s = message.toString();
-				if(s.indexOf("[object ") >= 0) {
-					s = JSON.stringify(message);
-				}
-				post(s);
-			}
-			else if(message === null) {
-				post("<null>");
-			}
-			else {
-				post(message);
-			}
-		}
-		post("\n");
-	}
-}
+  log: function() {
+    for (var i = 0, len = arguments.length; i < len; i++) {
+      var message = arguments[i];
+      if (message && message.toString) {
+        var s = message.toString();
+        if (s.indexOf('[object ') >= 0) {
+          s = JSON.stringify(message);
+        }
+        post(s);
+      } else if (message === null) {
+        post('<null>');
+      } else {
+        post(message);
+      }
+    }
+    post('\n');
+  }
+};
 
-function get_track_id(){
-	var thisTrack = new LiveAPI('this_device canonical_parent');
-	console.log("current track id:", thisTrack.id);
-	outlet(0, 'track_id', thisTrack.id);
+function get_track_id() {
+  var thisTrack = new LiveAPI('this_device canonical_parent');
+  console.log('current track id:', thisTrack.id);
+  outlet(0, 'track_id', thisTrack.id);
 }
-
diff --git a/scripts/rm-cache.js b/scripts/rm-cache.js
@@ -6,10 +6,12 @@ const fs = require('fs');
 
 const removeAllFilesAndFolders = (dirpath) => {
   if (!fs.existsSync(dirpath)) {
-    console.log('Folder does not exist:', dirpath); 
+    console.log('Folder does not exist:', dirpath);
     return;
   }
-  rimraf(path.join(dirpath, "*"), () => console.log("remove all items in", dirpath));
-}
+  rimraf(path.join(dirpath, '*'), () =>
+    console.log('remove all items in', dirpath)
+  );
+};
 
-cacheDirs.forEach(removeAllFilesAndFolders)
+cacheDirs.forEach(removeAllFilesAndFolders);