Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libfabric-sarus branch] --skip-resource-manager flag still requires an ip & port in config #32

Open
mattnappo opened this issue Aug 21, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mattnappo
Copy link
Collaborator

mattnappo commented Aug 21, 2023

In the libfabric-sarus branch, the executor manager will crash if the resource_manager_address or resource_manager_port fields in config/executor_manager.json are not set. This crash still happens even when the executor manager is run with --skip-resource-manager. I can work on a fix at some point, but I just wanted to document the bug.

Code breaks here: https://github.com/spcl/rFaaS/blob/libfabric-sarus/server/executor_manager/manager.cpp#L28

@mattnappo mattnappo added bug Something isn't working good first issue Good for newcomers labels Aug 21, 2023
@mcopik
Copy link
Contributor

mcopik commented Aug 23, 2023

@mattnappo Yes, it should be an easy fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants