Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgallery thumbnails fill width with sphinx-gallery 0.11 #655

Open
hakonanes opened this issue Jul 28, 2022 · 7 comments
Open

nbgallery thumbnails fill width with sphinx-gallery 0.11 #655

hakonanes opened this issue Jul 28, 2022 · 7 comments

Comments

@hakonanes
Copy link

hakonanes commented Jul 28, 2022

This nbsphinx gallery:

Reference frames
================

These tutorials cover the relevant reference frames in EBSD and how to determine the
detector-sample geometry, also known as the projection/pattern center (PC).

.. nbgallery::

    reference_frames
    pc_calibration_moving_screen_technique

looks like this with sphinx-gallery 0.10.1:

image

and like this with sphinx-gallery 0.11:

image

I'm afraid I don't know the reason for this. Are anyone else seeing this as well?

As a temporary solution, I'm pinning sphinx-gallery to < 0.11 in my projects.

@kburns
Copy link

kburns commented Jul 30, 2022

Yes seeing the same here, also pinning sphinx-gallery < 0.11 for now.

@mgeier
Copy link
Member

mgeier commented Aug 5, 2022

Thanks for reporting this!

I can reproduce the problem, but I will only have time to look into this after next week.

If somebody has any additional information, please let me know!

I'm of course also open for a pull request!

@hakonanes
Copy link
Author

I will only have time to look into this after next week.

That would be great! However, there is no rush to amend this behaviour with sphinx-gallery v0.11 from my side, at least.

@mgeier
Copy link
Member

mgeier commented Aug 28, 2022

I've made a first attempt for solving this at #666.

@mgeier
Copy link
Member

mgeier commented Jan 8, 2023

I'm leaning towards creating custom HTML and CSS for nbsphinx and to stop being compatible with Sphinx Gallery (sphinx-gallery/sphinx-gallery#1005 (comment)).

See mgeier#2 for a discussion, feel free to chime in!

@mgeier
Copy link
Member

mgeier commented Jan 21, 2023

I'm working on a potential solution in #706, please review!

@hakonanes
Copy link
Author

I built my documentation locally with the changes in #706, and found the changes to solve my issue.

The gallery tiles look very nice. And I like that the tooltip shows the full notebook description. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants