New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build bug] Modifying gumbo source doesn't cause rebuilds #2718
Comments
Thanks for opening this issue up, this has been mildly annoying me, too. It's a side effect of how I ended up implementing the libgumbo build, as a separate library and not part of the extension -- using the Maybe that was a mistake, especially given your notes about link-time optimization in #2331, and I should have picked |
This is definitely not a priority. I just noticed it and thought I'd make a note of it. |
Please describe the bug
Modifying the gumbo source files doesn't cause
rake compile:nokogiri
to rebuild the extension.Help us reproduce what you're seeing
rake compile:nokogiri
touch gumbo-parser/src/util.h
rake compile:nokogiri
Note that the extension was already compiled for the first invocation so nothing needed to be done. In the second compilation, it also thinks there's nothing to do. (The same holds true if you actually modify the file, not merely touch it, but touching is traditionally sufficient for build systems.)
Expected behavior
I expect the gumbo library to be recompiled (or at least the parts of it that were changed) and the
nokogiri.bundle
to be rebuilt.Environment
main
branch.The text was updated successfully, but these errors were encountered: