Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ditching domain_name? #16

Open
tarcieri opened this issue Apr 27, 2016 · 4 comments
Open

Consider ditching domain_name? #16

tarcieri opened this issue Apr 27, 2016 · 4 comments

Comments

@tarcieri
Copy link

domain_name transitively pulls in unf which in turn pulls in unf_ext. We've gotten some complaints about this in http.rb:

https://www.reddit.com/r/ruby/comments/4gdv0u/http_the_gem_200_a_fast_elegant_http_client_for/d2gqad6

Is it really necessary, and is the transitive dependency on a native extension worth it?

@adelcambre
Copy link

I'd 👍 this as well for a different reason. domain_name defines the top level constant DomainName which conflicts with one of the models in my application (and I imagine, others as well). This makes the prospect of upgrading to rest_client 1.8 significantly non-trivial.

@knu
Copy link
Member

knu commented Dec 9, 2016

Thanks for the pointer. When dropping support for ruby < 2.2, dependency on unf will be dropped. Hoping I could make it happen in a couple of months.

@tarcieri
Copy link
Author

tarcieri commented Dec 9, 2016

Awesome, great news!

@DGaffney
Copy link

DGaffney commented Jul 6, 2022

Hello from the future! It's still in here and its still requiring unf_ext, which currently blocks me from building windows containers in docker (I'll save explaining that nightmare for another time). Could we do this with URI instead? I'm happy to put out the PR if so.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants