ameliorate some shellcheck warnings

Author: spacelama

bin/notify-drift

@@ -16,9 +16,9 @@ export MAILTO=root
 OUTPUT=/tmp/ansible.daily.$USER.diff
 
 ESC=$'\e'
-ANSI_RE="$ESC[[0-9][^m]*m"
-ANSI_CYAN="$ESC\\[0;36m"  # "include"
-ANSI_GREEN="$ESC\\[0;32m" # "ok"
+ANSI_RE="$ESC\[[0-9][^m]*m"
+ANSI_RE_CYAN="$ESC\\[0;36m"  # "include"
+ANSI_RE_GREEN="$ESC\\[0;32m" # "ok"
 
 STDOUT=$( mktemp "/tmp/ansible.notify-drift.XXXXXX" ) || exit 1
 exec > $STDOUT 2>&1
@@ -29,7 +29,7 @@ exec > $STDOUT 2>&1
 normal --check > $OUTPUT.today.tmp 2>&1
 
 #summary_changes=$( grep -e "^${ANSI_RE}changed:" -e "^${ANSI_RE}fatal:" < $OUTPUT.today.tmp )
-summary_changes=$( grep "^$ESC" < $OUTPUT.today.tmp | grep -v -e "^$ANSI_GREEN" -e "^$ANSI_CYAN" )
+summary_changes=$( grep "^$ESC" < $OUTPUT.today.tmp | grep -v -e "^$ANSI_RE_GREEN" -e "^$ANSI_RE_CYAN" )
 
 (
     echo "     $OUTPUT"

files/tree/usr/local/bin/bash_error_handler.sh

@@ -1,4 +1,6 @@
 #!/usr/bin/env -S echo "This should not be run directly - try using the following command, perhaps configuring \$ERROR_CONTINUE, \$ERROR_PRINT_UNSAFE: \nsource"
+# -*- Mode: shell-script -*-
+# shellcheck shell=bash
 
 # source this from your script that wants backtraces from your error
 # handler:

files/tree/usr/local/bin/bash_trace_handler.sh

@@ -1,4 +1,6 @@
-#!/bin/bash
+#!/usr/bin/env -S echo "This should not be run directly - try using the following command, perhaps configuring \$ERROR_CONTINUE, \$ERROR_PRINT_UNSAFE: \nsource"
+# -*- Mode: shell-script -*-
+# shellcheck shell=bash
 
 # source this, and you get a nicer 'set -xv' output
 # https://news.ycombinator.com/item?id=44666984