Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lists are created with an extra empty line between rows #41

Closed
dotansimha opened this issue Jul 7, 2022 · 4 comments
Closed

Lists are created with an extra empty line between rows #41

dotansimha opened this issue Jul 7, 2022 · 4 comments
Assignees
@souvikinator
Labels
bug Something isn't working

Comments

@dotansimha
Copy link

dotansimha commented Jul 7, 2022 •
edited
Loading

Hi @souvikinator :)

We noticed an issue with the output of lists. We have the following Notion page (public):
https://www.notion.so/Roadmap-232f99f86aa34383bac5d72e53aa24b7

This is how it looks like on Notion:
image

We are converting the Notion page to Markdown and then publish it to GitHub as issue/discussion, and this is the result: dotansimha/graphql-yoga#1358

image

It seems like there is an additional line break between list rows:

image
@souvikinator
Copy link
Owner

Yep! I can reproduce it. Will fix the issue and create a release shortly.
Thanks for reporting.

@souvikinator souvikinator added the bug Something isn't working label Jul 7, 2022
@souvikinator souvikinator self-assigned this Jul 7, 2022
souvikinator added a commit that referenced this issue Jul 7, 2022
@souvikinator
Fix: Lists are created with an extra empty line #41
5b0c7e6
@dotansimha
Copy link
Author

Thank you! I saw you bumped to 2.5.1 but release is not yet on npm?

@souvikinator
Copy link
Owner

Yes! now it's live on NPM as well.
Thanks for the contribution :))

@souvikinator
Copy link
Owner

Closing the issue. Make sure to reopen this if the issue still persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@souvikinator souvikinator

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotansimha @souvikinator