[cos]Fixed issue by adding valid plugin class and change CosLogs as a hierarchy of Independent logs

[vteratipally]

Fixed issue by adding valid plugin class
change CosLogs as a hierarchy of Independent logs

Signed-off-by: Varsha Teratipally [email protected]

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• [] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3287
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[arif-ali]

curious, the valid_subclasses already has CosPlugin already at line 36

[TurboTurtle]

Line 36 needs to be removed, as it gets overwritten by the super() in __init__() from the base Policy class.

[arif-ali]

Does this mean that you don't want to be collecting all the logs defined in LogsBase as above?

[TurboTurtle]

This will make it so that CosLogs has the IndependentPlugin tagging class assigned to it, which will enable it for all distros, which is precisely why we made the change to split out LogsBase.

The change to valid_subclasses is correct (and can be made "more" correct by removing line 36), but this change here is not going to get us where we need to be.

[arif-ali]

can you also rebase your commit to the main branch that solves the CI for the snap build, and hence the rest of the checks