Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON config/ini file to launch instead of command line only #282

Open
Taha-Firoz opened this issue Aug 13, 2022 · 7 comments
Open

Add JSON config/ini file to launch instead of command line only #282

Taha-Firoz opened this issue Aug 13, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@Taha-Firoz
Copy link

I've worked in quiet a few designs in possible config files to launch the embedder from instead of the just command line parameters. It could help make it a lot clearer to start your application and configurations can be more detailed if we do.

@HidenoriMatsubayashi HidenoriMatsubayashi added the enhancement New feature or request label Aug 16, 2022
@HidenoriMatsubayashi
Copy link
Contributor

I think YAML is better than JSON for the config file.

@Taha-Firoz
Copy link
Author

True YAML is easier to write but I was pitching JSON because you already have RapidJson in your project which we could use to parse the file with.

@HidenoriMatsubayashi
Copy link
Contributor

RapidJson is too much to parse config files. And also we need to include it to the template of flutter-elinux if we use it.

@Taha-Firoz
Copy link
Author

So we just do it through flutter-elinux since it has json parsing included in it, or can we pull in a yaml parsing dep?

@HidenoriMatsubayashi
Copy link
Contributor

Technically, we have two options. First one is to parse the config file on flutter-elinux side and reflect it on the command line options. Second one is to implement a simple parser with embedder or template source code (Not flutter-elinux side).

@Taha-Firoz
Copy link
Author

I actually want to add something more with the config file, basically I want to add more control over DKMS. I'm having a similar conversation over in the flutter-pi embedder right now. It would be slightly easier for me to work on this because I am more familiar with the flutter-embedded-linux because I've basically been working with this project over 5-6 months at this point.

@HidenoriMatsubayashi
Copy link
Contributor

basically I want to add more control over DKMS

Please create another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants