Skip to content

Conversation

@phrfpeixoto
Copy link

I wanted to use this but had a custom celery config module, so I made this change to support it.

@coveralls
Copy link

coveralls commented Feb 28, 2021

Coverage Status

Coverage remained the same at 95.031% when pulling 9f93d2c on phrfpeixoto:custom_celeryconfig into cf8aa80 on sontek:master.

@sontek
Copy link
Owner

sontek commented Feb 28, 2021

@phrfpeixoto Could you implement this a little differently:

  • Keep use_celeryconfig as a boolean.
  • Introduce a new field celery_config_module (or a better name if you have one) and load it from there if set

So use_celeryconfig = true + celery_config_module = app.celeryconfig would do what you want, otherwise without a module said it would use the default behavior

@phrfpeixoto
Copy link
Author

Will do.

@phrfpeixoto phrfpeixoto force-pushed the custom_celeryconfig branch from 8b1cc35 to 13ce23c Compare March 3, 2021 19:56
@phrfpeixoto phrfpeixoto force-pushed the custom_celeryconfig branch from 13ce23c to 9f93d2c Compare March 3, 2021 19:58
@phrfpeixoto
Copy link
Author

@sontek Done.

@phrfpeixoto
Copy link
Author

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants