Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: On Dashboard page, "Last 7 Days" and "This Week" don't show the same time when a time entry is between two day. #208

Open
gungun974 opened this issue Oct 16, 2024 · 4 comments
Assignees

Comments

@gungun974
Copy link

This is a bug I seen from version 0.0.3 but it's seem nobody has report it yet.

Here so pictures to show the current state :

image

image1

This is not a major bug but it's always strange to me to see this at midnight.

@gungun974
Copy link
Author

Oh and also in the "Reporting page" and the "Activity Graph" my extra hours of midnight are added to yesterday.

So technically if I work more than 24h, I can have a day with more than 24h 👀

@Onatcer
Copy link
Contributor

Onatcer commented Oct 17, 2024

thanks for reporting it. Yes there is an inconsistency between those methods, we do have an internal issue for this as well, it just wasn't a priority.

The Last 7 days will calculate the time spent inside the 24h of a day, while the "This Week" section and Reporting sums up all time entries that started within this day. I think the underlying issue was that we split the day in 3-hour chunks to display the activity during the day and it felt more appropriate to calculate those as "time inside this timeframe" instead of "time entries started within this time frame". But that also means we would have an inconsistency between the Graph and the hours next to it if we used the "time entries started within this time frame" calculation. Thinking about it this is still less confusing than the current state tho.

I'm not sure exactly about the implementation details (@korridor can comment on that) but I assume that we will not change the method for calculation for reporting at this point and there are probably performance aspects to this as well. I'm also pretty sure all other time tracking applications I've used so far use the start date as a reference.

In any way it is possible to have more than 24h within a day, for the simple reason that we do not restrict overlapping time entries.

@korridor
Copy link
Contributor

@gungun974 Hi, thanks for your issue. So as @Onatcer wrote this in not really a bug since it does what I intended it to do, but I get that it's confusing.
Just to summarize:

  • "Last 7 Days": Calculation based on how much time was actually spent in this day/3 hours segment
  • All other charts, "This week" and the whole "Reporting" feature uses the start timestamp to determine the day a time entry belongs to

The calculation in the "Last 7 days" chart is much more complicated, which is why we used it only there since the other calculation based on the start timestamp is not usable there. We also researched before developing this feature and all competing products are using the calculation based on the start date and we are worried that if we used the other calculation and someone imports data from for example Clockify the reports would show different aggregates. Also we are currently working on an Excel/CSV export so that customers can do more customized calculations there and I think it would be confusing there as well since I highly doubt someone will do a calculation like the one we did for the "Last 7 Days" chart in Excel.

Since I fully get that this is confusing, we are looking for a better solution. Do you think that if the "Last 7 Days" chart would only show the chart, but not the Xh YYmin on the right and we add a tooltip with more information about the chart, that this would be less confusing?

@Onatcer
Copy link
Contributor

Onatcer commented Oct 22, 2024

@korridor imo showing Xh YYmin as the start timestamp based time and leaving the chart as is would be the easiest solution for now, if that is not too compute intensive. i think just removing the Xh YYmin will look weird.

There are currently no tooltips for the chart anyways, because the area is quite small, so realistically there is no way to tell that the calculations are different, from the interface alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants