-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share button doesn't change page URL #105
Comments
Yeah I think we pushed the work I was doing on the share button a bit prematurely. |
I misread the issue. There's no real issue. You are pointing out a behavior that seems confused (rightfully so!) |
I'd propose the following behavior:
|
It seems like neither of the suggested behaviors are live on https://stage-playground.solidjs.com/scratchpad — is it OK to reopen this issue? |
The share button changes the URL for me every time. Screen.Recording.2023-09-25.at.1.19.45.PM.mov |
As reported in Discord, clicking on the Share button copies the short URL to the clipboard, but doesn't change the page URL (
window.location
); it remains the long URL. This is confusing behavior.On the deployed site, I don't even see the brief change in icon to a chain link anymore (but I do see it on a dev server, even though it's failing to do the PUT).
The text was updated successfully, but these errors were encountered: