Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FRSM-13-R1 Not picking up install instructions or requirements #42

Open
PipGrylls opened this issue Jun 27, 2024 · 0 comments · May be fixed by #43
Open

[Bug]: FRSM-13-R1 Not picking up install instructions or requirements #42

PipGrylls opened this issue Jun 27, 2024 · 0 comments · May be fixed by #43
Labels
bug Something isn't working

Comments

@PipGrylls
Copy link

PipGrylls commented Jun 27, 2024

This check fails although we seem to meet the intention of the measure.

Description

In https://github.com/paramm-team/pybamm-param/tree/main we have the line ## 🚀 Install pybamm-param but we fail FRSM-13-R1-1

Equally we have dependencies and a pypi release which isn't found and we fail FRSM-13-R1-2

Expected Behavior

I think that it should fine the ‘installing/install’ in the title and also the requirements.txt/requirements in pyproject.toml

Actual Behavior

Steps to reproduce

  1. Put our github link into the fuji tool

Additional Context

@PipGrylls PipGrylls added the bug Something isn't working label Jun 27, 2024
RyanJField added a commit to RyanJField/fuji that referenced this issue Aug 29, 2024
@RyanJField RyanJField linked a pull request Aug 29, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant