Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainbow Indent doesn't play nice #19

Open
locks opened this issue Jan 30, 2019 · 2 comments
Open

Rainbow Indent doesn't play nice #19

locks opened this issue Jan 30, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@locks
Copy link

locks commented Jan 30, 2019

I have rainbow indent installed and enabled in Visual Studio Code, and when using it in conjunction with soft era, this is the visual result:

image

I don't know if it's possible (or desired) to configure rainbow indent's color from your plugin, but at least a suggestion for what colors to use would be useful.

Thank you!

@lovemecomputer
Copy link
Member

oo thanks @locks ! i'll look in to see if there's a way to define colors in the theme.

in the meantime, there are some instructions here to customize ur own colors: https://marketplace.visualstudio.com/items?itemName=oderwat.indent-rainbow

when i get a chance, i'll see about adding color rules to this theme, and if that's not possible, put a color customization code snippet in the readme!

@lovemecomputer lovemecomputer added good first issue Good for newcomers enhancement New feature or request labels Feb 4, 2019
@lovemecomputer
Copy link
Member

hmm i just installed rainbow indent and it looks like it's playing nicer with light themes now.

Screen Shot 2019-05-08 at 12 36 18 PM

however i wanna tinker with it to see if i can find a sort of "suggested config", so i'll keep this issue open for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants