Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to indicate latest flash on Belkin RT3200 #633

Closed
sarcasticadmin opened this issue Nov 8, 2023 · 6 comments
Closed

How to indicate latest flash on Belkin RT3200 #633

sarcasticadmin opened this issue Nov 8, 2023 · 6 comments
Labels

Comments

@sarcasticadmin
Copy link
Member

Description

From the discussion #532 (comment)

True, but they are both triple LEDs capable of rendering multiple colors, therefore we could use different colors of internet LED (or even power LED) potentially for conference version signaling.

I’ll note that on the RT3200, the factory firmware uses the power LED to indicate WPS pairing enabled.

Owen

Acceptance Criteria

  • Identify the best way to visually indicate the current build
  • Implement the change via the LED mechanisms in Openwrt
@owendelong
Copy link
Collaborator

Unless anyone has better ideas, I propose the following color code for the "Internet LED":

Year Ending: Color:
0 Blue (0x0000ff)
1 White (0xffffff)
2 Amber (0xffc000)
3 Green (0x00ff00)
4 Red (0xff0000)
5 Cyan (0x00ffff)
6 Magenta (0xff00ff)
7 Yellow (0xffff00) -- close to Amber, but if 5 year old firmware, obvious in other ways.
8 Pink (0xff8080) -- we should make sure this is easily distinguishable from red and magenta
9 Bright Green (0x80ff80) -- We should make sure this is easily distinguishable from green

Further, I propose the following for the power LED:
Power not good: Black (0x000000) -- Likely we can't change this if the power isn't on. ;-)
Power good, internet unreachable -- Red (0xff0000)
Power good, internet available, 2.4g OK, 5g down -- Yellow (0xffff00)
Power good, internet available, 2.4g down, 5g OK -- Magenta (0xff00ff)
Power good, internet available, 2.4g OK, 5g OK -- White (0xffffff)

Feedback welcomed and encouraged.

@sarcasticadmin
Copy link
Member Author

Thanks @owendelong Im good with this proposal.

The only thing I would want to confirm is that it doesnt conflict with the existing LED states of the AP. Things like ready to flash or flash failed are the ones that come to mind. Typically in these states the LED is blink so maybe its not an issue though

@owendelong
Copy link
Collaborator

Wouldn't context be sufficient for this as well? We know when we're flashing or trying to flash something, so we wouldn't expect to see those blinking states in the wild and they'd be pretty distinctive when we are flashing, I would think.

Since we wouldn't take control of the LEDs to represent our intended state until our flashed-on firmware is loaded and running and networked, I don't think there's a conflict. Let me know if you think I'm missing something important.

It does occur to me that I didn't have a state to represent Power good, internet available, all radios down. Perhaps we should make that Yellow and make Power + 2.4G OK, 5G down Green (0x00ff00) instead.

@davidelang
Copy link
Collaborator

davidelang commented Nov 8, 2023 via email

@owendelong
Copy link
Collaborator

I don't think there's a "free slot" issue here. We have at least 10 easily distinguishable colors (likely considerably more) on each of 2 LEDs... If we're really worried, that gives us at least 100 different meanings we could convey, but I really don't want to make this that complex.

However, if we want to indicate other things beyond what I've proposed for power, I don't think we need to give up the individual radio indications to do so.

@sarcasticadmin
Copy link
Member Author

Closing since the Belkin 3200 mt-7622 has been superseded by the Openwrt One mt798x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants