Skip to content

Commit 4957db7

Browse files
authored
Merge pull request #6031 from snyk/chore/cli-946_remove-snyk-fix-cta
chore: remove snyk fix call-to-action
2 parents ccfde78 + 799aa16 commit 4957db7

File tree

6 files changed

+2
-136
lines changed

6 files changed

+2
-136
lines changed

src/lib/formatters/show-fix-tip.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/lib/formatters/test/format-test-results.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import { isNewVuln, isVulnFixable } from '../../vuln-helpers';
2424
import { jsonStringifyLargeObject } from '../../json';
2525
import { createSarifOutputForOpenSource } from '../open-source-sarif-output';
2626
import { getSeverityValue } from '../get-severity-value';
27-
import { showFixTip } from '../show-fix-tip';
2827
import {
2928
DockerFileAnalysisErrorCode,
3029
facts as dockerFacts,
@@ -172,9 +171,6 @@ export function getDisplayedOutput(
172171
const summary =
173172
testedInfoText + ', ' + chalk.red.bold(vulnCountText) + hasUnknownVersions;
174173

175-
const fixTip = showFixTip(projectType, res, options);
176-
const fixAdvice = fixTip ? `\n\n${fixTip}` : '';
177-
178174
const dockerfileWarning = getDockerfileWarning(res.scanResult);
179175
const dockerSuggestion = getDockerSuggestionText(options, res);
180176
const dockerDocsLink = getDockerRemediationDocsLink(dockerAdvice, config);
@@ -225,9 +221,9 @@ export function getDisplayedOutput(
225221
meta;
226222

227223
if (res.remediation) {
228-
body = summary + body + fixAdvice;
224+
body = summary + body;
229225
} else {
230-
body = body + '\n\n' + summary + fixAdvice;
226+
body = body + '\n\n' + summary;
231227
}
232228

233229
const ignoredIssues = '';

test/acceptance/workspaces/pip-app-transitive-vuln/cli-output-actionable-remediation.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,3 @@ Project name: pip-app-transitive-vuln
2929
Open source: no
3030
Project path: pip-app-transitive-vuln
3131

32-
Tip: Try `snyk fix` to address these issues.`snyk fix` is a new CLI command in that aims to automatically apply the recommended updates for supported ecosystems.
33-
See documentation on how to enable this beta feature: https://docs.snyk.io/snyk-cli/fix-vulnerabilities-from-the-cli/automatic-remediation-with-snyk-fix#enabling-snyk-fix

test/acceptance/workspaces/pip-app-transitive-vuln/cli-output.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,3 @@ Project path: pip-app-transitive-vuln
4444

4545
Tested 6 dependencies for known vulnerabilities, found 4 vulnerabilities, 4 vulnerable paths.
4646

47-
Tip: Try `snyk fix` to address these issues.`snyk fix` is a new CLI command in that aims to automatically apply the recommended updates for supported ecosystems.
48-
See documentation on how to enable this beta feature: https://docs.snyk.io/snyk-cli/fix-vulnerabilities-from-the-cli/automatic-remediation-with-snyk-fix#enabling-snyk-fix

test/jest/unit/lib/formatters/show-fix-tip.spec.ts

Lines changed: 0 additions & 94 deletions
This file was deleted.

test/jest/unit/lib/formatters/test/__snapshots__/display-result.spec.ts.snap

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,6 @@ Open source: no
261261
Project path: src
262262
Licenses: enabled
263263
264-
Tip: Try \`snyk fix\` to address these issues.\`snyk fix\` is a new CLI command in that aims to automatically apply the recommended updates for supported ecosystems.
265-
See documentation on how to enable this beta feature: https://docs.snyk.io/snyk-cli/fix-vulnerabilities-from-the-cli/automatic-remediation-with-snyk-fix#enabling-snyk-fix
266-
267264
Tip: Detected multiple supported manifests (3), use --all-projects to scan all of them at once."
268265
`;
269266

0 commit comments

Comments
 (0)