Fix install script #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebling
approved these changes
Dec 22, 2021
|
|
||
| if [ -n $(command -v curl) ] |
There was a problem hiding this comment.
It's common to support wget in the install script
| @@ -1,11 +1,10 @@ | |||
| #! /bin/bash -e | |||
| #!/bin/bash | |||
|
@maxjeffos any chance this will be merged? Install script is still broken. |
codebling
reviewed
Dec 22, 2021
|
|
||
| version="$(cat plugin.yaml | grep "version" | cut -d '"' -f 2)" | ||
| latest_version=$(curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -i "location" | sed s#.*tag/##g | tr -d "\r") | ||
| latest_version=$(curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -E "^Location:" | rev | cut -d"/" -f1 | rev | tr -d "\r\n") |
There was a problem hiding this comment.
Needs case insensitive for the header
Suggested change
| latest_version=$(curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -E "^Location:" | rev | cut -d"/" -f1 | rev | tr -d "\r\n") | |
| latest_version=$(curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -Ei "^Location:" | rev | cut -d"/" -f1 | rev | tr -d "\r\n") |
There was a problem hiding this comment.
Also not sure everyone will have rev cut and tr.
With sed:
curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -Ei "^Location:" | sed -E 's:^.*/::'
With grep only
curl -Is "https://github.com/snyk-labs/helm-snyk/releases/latest" | grep -Ei "^Location:" | grep -Eo ' \S+' | grep -Eo '[^/]+$'
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60 as well as fixing other issues in the script.