Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FLOAT types with NUMERIC #8

Open
miike opened this issue Oct 4, 2018 · 3 comments
Open

Replace FLOAT types with NUMERIC #8

miike opened this issue Oct 4, 2018 · 3 comments

Comments

@miike
Copy link

miike commented Oct 4, 2018

By replacing some of the current transaction FLOAT types with NUMERIC we avoid any floating point arithmetic issues that we can run into if using BigQuerys FLOAT64.

@chuwy
Copy link
Contributor

chuwy commented Feb 16, 2019

8653b16

@dilyand
Copy link
Contributor

dilyand commented Mar 6, 2020

@chuwy Can this be closed?

@chuwy
Copy link
Contributor

chuwy commented Mar 9, 2020

No, I think we still need this change. BQ Loader is shipped with schema-ddl 0.9.0 since 0.2.0, which means it creates new columns with NUMERIC type snowplow/iglu#426. Now we need to cherry-pick 8653b16 to reflect this standard atomic events fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants