Repeater: consider reducing nack logging

[chuwy]

Repeater checks every time if event is old enough to make an insertion attempt. However, it checks it after every pull which happens very often. As a result we have messages like:

DEBUG com.snowplowanalytics.snowplow.storage.bigquery.repeater.Repeater - Event fcbcc0b1-e51b-488b-9a90-7403cdfb19f4/2020-02-19T21:53:36.943Z is not ready yet. Nack

Printed every 300 milliseconds.

However, this is logged with DEBUG level, which means user can technically get rid of it.

[istreeter]

I think it is reasonable to keep existing behaviour and print this at debug level.

As long as we fix filename logging (#222) then nobody should need to turn on debug level in production, and then the current nack logging is harmless.

[dilyand]

It would be best to make the period longer though. 300ms is too often. It makes debugging a pain because of how chatty it is.

…

On 27 Oct 2021, 21:41 +0100, Ian Streeter ***@***.***>, wrote: I think it is reasonable to keep existing behaviour and print this at debug level. As long as we fix filename logging (#222) then nobody should need to turn on debug level in production, and then the current nack logging is harmless. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.