Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent event deduplication between loader and repeater #217

Open
istreeter opened this issue Oct 1, 2021 · 0 comments
Open

Consistent event deduplication between loader and repeater #217

istreeter opened this issue Oct 1, 2021 · 0 comments

Comments

@istreeter
Copy link
Contributor

istreeter commented Oct 1, 2021

As described in #144, the repeater uses event_id as an insert id, which means two events with the same id are deduplicated when inserted to the table. The loader does no such event deduplication.

Event deduplication should at least be consistent. Either, a user should expect two events with the same event_id to be both in the table, or not. It should not depend on which component loaded the event.

If we go the route of full deduplication then we should understand the performance impact first. We could consider making this a configurable option, to toggle either behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant